Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update feature parsing for app checks and secure_light #22

Merged
merged 1 commit into from
May 25, 2023

Conversation

aroberts87
Copy link
Collaborator

  • Add configuration.security=light support into the config parser
  • Optimize the flow of configuration parsing for both Monitor and Secure
  • Re-work the layout of the features.monitoring.app_checks block to utilize enabled and applications fields. This is needed because the app checks are handled differently than the other configurations in the agent in that the app_checks key in the agent configuration does not have a nested enabled key, but instead leveraged a separate, top level parameter called app_checks_enabled.

* Add `configuration.security=light` support into the config parser
* Optimize the flow of configuration parsing for both Monitor and Secure
* Re-work the layout of the `features.monitoring.app_checks` block to
  utilize `enabled` and `applications` fields. This is needed because the app
  checks are handled differently than the other configurations in the agent
  in that the `app_checks` key in the agent configuration does not have a
  nested `enabled` key, but instead leveraged a separate, top level parameter
  called `app_checks_enabled`.
@aroberts87 aroberts87 requested a review from mavimo May 24, 2023 16:58
@aroberts87 aroberts87 merged commit c149084 into main May 25, 2023
@aroberts87 aroberts87 deleted the feature_fixes branch May 25, 2023 18:15
@aroberts87 aroberts87 added the bug Something isn't working label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant