fix: reduce complexities of kernel devel detections for EL distros #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Install Kernel Headers (7/8)` steps in the AlmaLinux, CentOSLinux, and RockyLinux dependency tasks utilized `vars` to loop over the supported kernel types to determine the required kernel-devel package name. Though running `ansible-lint` it was found that the way we were using `vars`, while working, was failing schema validations as the `vars` field expects an object and not a list like we were providing. This change removes the complexities created by that logic and will instead result in needing to create a dedicated file for Oracle Linux dependencies if we choose to add support for that distribution in the Role in the future.
aroberts87
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Install Kernel Headers (7/8)steps in the AlmaLinux, CentOSLinux, and RockyLinux dependency tasks utilizedvarsto loop over the supported kernel types to determine the required kernel-devel package name. Though runningansible-lintit was found that the way we were usingvars, while working, was failing schema validations as thevarsfield expects an object and not a list like we were providing. This change removes the complexities created by that logic and will instead result in needing to create a dedicated file for Oracle Linux dependencies if we choose to add support for that distribution in the Role in the future.