Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated imp module with importlib #166

Closed
hugovk opened this issue Apr 29, 2023 · 1 comment · Fixed by #168
Closed

Replace deprecated imp module with importlib #166

hugovk opened this issue Apr 29, 2023 · 1 comment · Fixed by #168

Comments

@hugovk
Copy link

hugovk commented Apr 29, 2023

This project's tests use the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

snapshottest/snapshottest/module.py

Line 36 in 24b8b47

source = imp.load_source(self.module, self.filepath)

@hugovk hugovk mentioned this issue May 3, 2023
Open
31 tasks
@MarcellPerger1 MarcellPerger1 mentioned this issue Jul 18, 2023
Merged
@wongcht wongcht mentioned this issue Aug 30, 2023
Closed
@matti-lamppu matti-lamppu mentioned this issue Nov 3, 2023
Merged
@jamesoutterside jamesoutterside mentioned this issue Nov 16, 2023
Merged
@kwinkunks kwinkunks mentioned this issue Dec 19, 2023
Merged
kwinkunks added a commit to equinor/open_petro_elastic that referenced this issue Dec 20, 2023
@kwinkunks
Switch to using syrupy
04de7d9 
pytest-snapshottest uses imp, which was deprecated in 3.11 and gone now.
They don't look like moving
syrusakbary/snapshottest#166

Conflicts:
	.github/workflows/python-build-test.yml
This was referenced Dec 20, 2023
Open
Closed
kwinkunks added a commit to equinor/open_petro_elastic that referenced this issue Dec 20, 2023
@kwinkunks
Switch to using syrupy
c9a1343 
pytest-snapshottest uses imp, which was deprecated in 3.11 and gone now.
They don't look like moving
syrusakbary/snapshottest#166

Conflicts:
	.github/workflows/python-build-test.yml
kwinkunks added a commit to equinor/open_petro_elastic that referenced this issue Dec 21, 2023
@kwinkunks
Switch to using syrupy
37ba8b4 
pytest-snapshottest uses imp, which was deprecated in 3.11 and gone now.
They don't look like moving
syrusakbary/snapshottest#166

Conflicts:
	.github/workflows/python-build-test.yml
kwinkunks added a commit to equinor/open_petro_elastic that referenced this issue Dec 21, 2023
@kwinkunks
Switch to using syrupy
8b257cb 
pytest-snapshottest uses imp, which was deprecated in 3.11 and gone now.
They don't look like moving
syrusakbary/snapshottest#166

Conflicts:
	.github/workflows/python-build-test.yml
kwinkunks added a commit to equinor/open_petro_elastic that referenced this issue Dec 21, 2023
@kwinkunks
Modernize build system (#42)
7892da4 
* Modernize build system

Fixes #28. Also updating GitHub workflows, README/CONTRIBUTING, etc.

* Switch to using syrupy

pytest-snapshottest uses imp, which was deprecated in 3.11 and gone now.
They don't look like moving
syrusakbary/snapshottest#166

Conflicts:
	.github/workflows/python-build-test.yml
@RobinTail RobinTail mentioned this issue Feb 12, 2024
Merged
@RobinTail RobinTail mentioned this issue Apr 12, 2024
Closed
@bblanchon
Copy link

bblanchon commented Apr 24, 2024 •
edited
Loading

With Python 3.12, we now get the following error:

ModuleNotFoundError: No module named 'imp'

Please merge one of the available PRs 🙏

@c0rydoras c0rydoras mentioned this issue May 14, 2024
Merged
@intgr intgr mentioned this issue May 14, 2024
Closed
@Kilo59 Kilo59 mentioned this issue May 23, 2024
Merged
@ayys ayys closed this as completed in #168 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use importlib instead of imp MarcellPerger1/snapshottest
2 participants
@hugovk @bblanchon