Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support nested classes #99

Merged
merged 7 commits into from
Jan 12, 2020
Merged

fix: support nested classes #99

merged 7 commits into from
Jan 12, 2020

Conversation

iamogbz
Copy link
Collaborator

@iamogbz iamogbz commented Jan 12, 2020

Description

Refactors base extension to remove subdirectory prop.

Bumps the python package to beta.

Related Issues

Checklist

  • This PR has sufficient test coverage.
  • I have updated the CHANGELOG.md.

Additional Comments

No additional comments.

@codecov
Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #99   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         710    702    -8     
=====================================
- Hits          710    702    -8

@iamogbz iamogbz changed the title refactor: remove reliance on sub dir name prop fix: support nested classes Jan 12, 2020
@iamogbz iamogbz requested a review from noahnu January 12, 2020 03:01
CHANGELOG.md Outdated Show resolved Hide resolved
@iamogbz iamogbz requested a review from noahnu January 12, 2020 04:49
@iamogbz iamogbz merged commit 1e22b06 into master Jan 12, 2020
@iamogbz iamogbz deleted the refactor-patch-1 branch January 12, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nested test classes Argument conflict when trying to replace snapshottest
2 participants