Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace isort with ruff #910

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Oct 21, 2024

Description

Related Issues

Checklist

  • This PR has sufficient documentation.
  • This PR has sufficient test coverage.
  • This PR title satisfies semantic convention.

Additional Comments

No additional comments.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   97.74%   97.74%   -0.01%     
==========================================
  Files          21       21              
  Lines        1597     1596       -1     
==========================================
- Hits         1561     1560       -1     
  Misses         36       36              

🚨 Try these New Features:

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@epenet
Copy link
Contributor Author

epenet commented Oct 28, 2024

@noahnu what do you think of this isort migration?
One step towards moving more to ruff...

@noahnu noahnu merged commit 84081f6 into syrupy-project:main Nov 3, 2024
15 of 17 checks passed
@epenet epenet deleted the 20241021-1532 branch November 3, 2024 22:34
@noahnu
Copy link
Collaborator

noahnu commented Nov 23, 2024

🎉 This PR is included in version 4.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants