Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raw single should use the same name for snapshot and file #91

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

iamogbz
Copy link
Collaborator

@iamogbz iamogbz commented Jan 7, 2020

Description

Ensures raw single serializers use the same name for discovered snapshots and written files

Related Issues

Checklist

  • This PR has sufficient test coverage.

Additional Comments

N/A

@iamogbz iamogbz requested a review from noahnu January 7, 2020 23:42
Copy link
Collaborator

@noahnu noahnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR LGTM

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #91   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         714    716    +2     
=====================================
+ Hits          714    716    +2

@iamogbz iamogbz merged commit c7968fd into master Jan 7, 2020
@iamogbz iamogbz deleted the fix-90 branch January 7, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syrupy is deleting newly created snapshots when parametrizing a class method
2 participants