Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fail unused snapshots #77

Merged
merged 14 commits into from
Dec 29, 2019
Merged

feat: fail unused snapshots #77

merged 14 commits into from
Dec 29, 2019

Conversation

iamogbz
Copy link
Collaborator

@iamogbz iamogbz commented Dec 29, 2019 •
edited
Loading

Description

Makes syrupy fail test session on unused snapshots.
Adds a flag --snapshot-warn-unused which can be used to allow warnings.

Related Issues

Checklist

  • This PR has sufficient test coverage.

Additional Comments

No additional comments.

@iamogbz iamogbz requested a review from noahnu December 29, 2019 00:30
@codecov
Copy link

codecov bot commented Dec 29, 2019 •
edited
Loading

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #77   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         540    553   +13     
=====================================
+ Hits          540    553   +13
Impacted Files Coverage Δ
src/syrupy/serializers/amber.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d594b9a...dd82ae4. Read the comment docs.

@noahnu noahnu self-assigned this Dec 29, 2019
noahnu
noahnu reviewed Dec 29, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@iamogbz iamogbz requested a review from noahnu December 29, 2019 04:18
noahnu
noahnu reviewed Dec 29, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@iamogbz iamogbz requested a review from noahnu December 29, 2019 04:54
noahnu
noahnu approved these changes Dec 29, 2019
View reviewed changes
Copy link
Collaborator

@noahnu noahnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahnu noahnu merged commit ef118b8 into master Dec 29, 2019
@noahnu noahnu deleted the fail-unused branch December 29, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahnu noahnu noahnu approved these changes

Assignees

@noahnu noahnu

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail when there are unused snapshots
2 participants
@iamogbz @noahnu