Add support for US Core 3.1.1 and 6.1.0 #1450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for US Core 3.1.1 and 6.1.0 and makes 6.1.0 the new default. (My understanding is that since 5 is no longer relevant for certification in the US, nobody is likely to use it much but it's still there anyway) The code is starting to be kind of a mess so I started thinking about breaking all the US Core changes into a separate file, but to keep the diff here minimal I ultimately kept things all in the same file. Happy to refactor & break things out if people want that.
This chart was helpful in describing when things were added/removed from US Core: https://hl7.org/fhir/us/core/STU6.1/changes-between-versions.html
Note that just like for 4 & 5, the included documentreference-type VS for 3 and 6 was pre-loaded with the codes we actually use. (The official version uses a compose which apparently our internal ValidationSupport can't handle)
The one module change is in response to a validator error that required that "magic" code to be present.
In addition to the unit tests I used this little script to call the CLI validator to test out the different versions, see output files validate_results_uscore_${v}.txt for results:
There will still be some errors using the CLI validator like "Unknown code 'X9999-0'" (for our custom codes) and "Error from http://tx.fhir.org/r4: Unknown filter "tty = SCDG"" (Grahame says this is a VSAC problem) but there shouldn't be anything that suggests a profile error.