Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): update toast design #299

Merged
merged 5 commits into from
Aug 31, 2022
Merged

fix(ui): update toast design #299

merged 5 commits into from
Aug 31, 2022

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Aug 30, 2022 •
edited
Loading

Changes

  • update toast styles

Notes

Linear Gradient using react-native-linear-gradient, plus a BlurView for iOS

Preview

success info error
Simulator Screen Shot - iPhone 13 - 2022-08-30 at 20 32 07 Simulator Screen Shot - iPhone 13 - 2022-08-30 at 20 32 43 Simulator Screen Shot - iPhone 13 - 2022-08-30 at 20 32 17

Android:
Screenshot_1661884313

@pwltr pwltr self-assigned this Aug 30, 2022
@pwltr pwltr added the enhancement New feature or request label Aug 30, 2022
@pwltr pwltr force-pushed the fix/update-toasts branch from 42d2980 to 0a59b87 Compare August 31, 2022 08:08
limpbrains
limpbrains requested changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@limpbrains limpbrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please try react-native-skia to draw the gradient? It is already in our dependencies. Take a look at components/VerticalShadow for an example

@pwltr pwltr force-pushed the fix/update-toasts branch from 0a59b87 to aad0097 Compare August 31, 2022 14:07
@pwltr pwltr requested a review from limpbrains August 31, 2022 14:08
@pwltr
Copy link
Collaborator Author

pwltr commented Aug 31, 2022

I also rebased this onto #294 and enabled blur for Android.

@limpbrains
Copy link
Collaborator

Looks awesome!

@limpbrains limpbrains merged commit f2b7756 into master Aug 31, 2022
@limpbrains limpbrains deleted the fix/update-toasts branch August 31, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

@MiguelMedeiros MiguelMedeiros Awaiting requested review from MiguelMedeiros

Assignees

@pwltr pwltr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwltr @limpbrains