Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce PIN attempts in Send and ChangePIN flows #2311

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: reduce PIN attempts in Send and ChangePIN flows #2311

merged 1 commit into from
Oct 16, 2024

Conversation

limpbrains
Copy link
Collaborator

@limpbrains limpbrains commented Oct 14, 2024 •
edited
Loading

Description

  • extract all complex PIN logic to the hook
  • use this hook in all 3 flows: General auth, Change PIN, Send flows
  • disable annoying eslint rule, we don't need it, we have prettier

Linked Issues/Tasks

Type of change

Bug fix

Tests

Detox test

@limpbrains limpbrains marked this pull request as ready for review October 15, 2024 15:20
@limpbrains limpbrains requested a review from pwltr October 15, 2024 15:21
pwltr
pwltr approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@pwltr pwltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM

pwltr
pwltr reviewed Oct 16, 2024
View reviewed changes
src/components/PinPad.tsx Outdated Show resolved Hide resolved
@limpbrains limpbrains merged commit ff1cb6b into master Oct 16, 2024
6 of 7 checks passed
@limpbrains limpbrains deleted the pin branch October 16, 2024 12:14
@limpbrains limpbrains mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwltr pwltr pwltr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limpbrains @pwltr