Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Transfer to savings flow can auto-deselect connections, ignore user-selected connections and force to close all connections #2262

Closed
catch-21 opened this issue Sep 30, 2024 · 3 comments · Fixed by #2305
Assignees
Labels
bug Something isn't working

Comments

@catch-21
Copy link
Contributor

catch-21 commented Sep 30, 2024

Describe the bug

With two LN connections, proceeding to transfer from spending to saving automatically deselected all available connections but still applied the sum of all as the total. When manually enabling one back to enabled the sum of all is still applied.

I don't believe there is a valid reason for this, it shouldn't happen under any circumstance.

Reproduce

Steps from the attached screen recording

  • 0:00 to 0:24 Shows current two LN connections (one is from a regular BT order and the other is a manually set up connection). The latest manual transfer activity is also shown.
  • 0:27 begins the Transfer to Savings flow
  • 0:32 tap 'Advanced' button to choose connection to close, it automatically deselects and changes the order of the two listed connections
  • 0:38 I navigate back but the total is still sum of both connections (115_063)
  • 0:42 tap 'Advance' button again, it automatically deselects both connections again
  • 0:46 I select one of them (56_565) and tap 'Continue
  • 0:51 the total is still sum of both connections (115_063). I swipe to transfer.
  • 1:11 Two 'Transfer from Savings' Activities appear

Screenshots / Recording

autotoggle.mp4

Operating system

Android 14

Bitkit version

1.0.5 (136)

Log output

bitkit_ldk_logs_1727676385522.zip

@catch-21 catch-21 added bug Something isn't working triage This issue needs to be looked over by the team labels Sep 30, 2024
@pwltr pwltr removed the triage This issue needs to be looked over by the team label Sep 30, 2024
@pwltr
Copy link
Collaborator

pwltr commented Sep 30, 2024

Having a hard time reproducing this. Any additional steps that could lead to this? I tested on iOS simulator, Android emulator and on my mainnet Android build.

@catch-21
Copy link
Contributor Author

catch-21 commented Oct 9, 2024

@pwltr Yes, I think it happens if you leave it long enough, try leaving it for 2-3 minutes. Perhaps there is a background refresh occurring that causes it. If so, it could happen shortly after arriving at this page by chance. This was on my android device:

untoggle.mp4

@catch-21
Copy link
Contributor Author

catch-21 commented Nov 4, 2024

Verified on 1.0.6 (138) by waiting on the 'Select funds to transfer' page for 3 minutes. Toggles never move by themselves and always work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants