Chore: remove empty batches #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
take concat_batches into compute_aggregates function again
gokselk
pushed a commit
to gokselk/datafusion-upstream
that referenced
this pull request
Dec 19, 2024
…pache#13422) * Eliminate duplicated filter within (filter(TableScan)) plan (synnada-ai#51) * Eliminate duplicated filter within (filter(TableScan)) plan * Updates * fix * add test * fix * Preserve the filter order when eliminating duplicated filter synnada-ai#56 * Use IndexSet instead of Vec
|
Can we close this now? |
|
Upstream PR has been merged: apache#13794, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Some plans generate and emit empty RecordBatches. Since this behavior is unnecessary and incurs costs during stream execution, this change implements a solution for handling them in the streaming process.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?