Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not operator overload for SortOptions #1

Closed
wants to merge 5 commits into from

Conversation

berkaysynnada
Copy link
Collaborator

@berkaysynnada berkaysynnada commented Feb 16, 2023

Which issue does this PR close?

Closes apache#3726.

Rationale for this change

! operator can be used for SortOptions type to take reverse sort.

What changes are included in this PR?

! operator is overloaded for SortOptions to invert boolean fields of the struct.

Are there any user-facing changes?

No.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mustafasrepo
Copy link

You can send to the apache repo

@mustafasrepo
Copy link

Merged upstream

@berkaysynnada berkaysynnada deleted the feature/sort_options branch February 17, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

! (not) operator overload for SortOptions
3 participants