Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented GitHub Actions workflow for automated binary file building. #433

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

DainiusSal
Copy link

@DainiusSal DainiusSal commented Oct 6, 2022

Implemented an automated building of binary files through GitHub Actions workflow. The action executes automatically after a new release is created and uploads the binary files and the signature file to the release assets.

Notes:

  1. All files could be compiled using make release command in the future. darwin-arm64 binary requires MacOS to be built and it is the most expensive machine on GitHub Actions, so not worth building everything on it.
  2. There needs to be two extra secrets added to the repository: GPG_PRIVATE_KEY and GPG_PASSPHRASE for signing the binaries (more information here)

.github/workflows/build-release.yml Outdated Show resolved Hide resolved
.github/workflows/build-release.yml Show resolved Hide resolved
.github/workflows/build-release.yml Show resolved Hide resolved
@DainiusSal DainiusSal requested a review from synfinatic October 10, 2022 10:46
@synfinatic
Copy link
Owner

LGTM at this point, but I would request that the 4 commits are squashed. Thanks!

@DainiusSal
Copy link
Author

Squashed the commits :)

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #433 (bd6ac6e) into main (33d6564) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   78.30%   78.30%           
=======================================
  Files          23       23           
  Lines        2608     2608           
=======================================
  Hits         2042     2042           
  Misses        498      498           
  Partials       68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d6564...bd6ac6e. Read the comment docs.

@synfinatic synfinatic merged commit 0ce7584 into synfinatic:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants