Force a cache refresh when doing config-profiles
#431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't doing any cache expiration detection or anything so new users could end up with an empty list or users might end up with out dated profiles. Fixes: #420
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
=======================================
Coverage 78.30% 78.30%
=======================================
Files 23 23
Lines 2608 2608
=======================================
Hits 2042 2042
Misses 498 498
Partials 68 68 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't doing any cache expiration detection or anything so new users could end up with an empty list or users might end up with out dated profiles.
Fixes: #420