Tell Koanf to treat AccountIds as a string #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synfinatic
force-pushed
the
leading-zero-accountids
branch
from
f412318 to
2b22612
Compare
synfinatic
changed the title
Codecov Report
@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 56.97% 56.81% -0.17%
==========================================
Files 12 12
Lines 1827 1857 +30
==========================================
+ Hits 1041 1055 +14
- Misses 702 714 +12
- Partials 84 88 +4
Continue to review full report at Codecov.
|
synfinatic
force-pushed
the
leading-zero-accountids
branch
2 times, most recently
from
e0bbdfb to
4557747
Compare
Koanf does not follow the YAML spec and treats all keys as a string internally before converting to their final form. In the case of AWS AccountIds, this can result in a crash when the account has a leading zero which is common.. Add Codecov banner. Fixes: #292
synfinatic
force-pushed
the
leading-zero-accountids
branch
from
4557747 to
b030718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Koanf does not follow the YAML spec and treats all keys as a
string internally before converting to their final form. In the
case of AWS AccountIds, this can result in a crash when the account
has a leading zero which is common..
Fixes: #292