Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove console --use-sts, add --prompt #173

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Remove console --use-sts, add --prompt #173

merged 1 commit into from
Dec 14, 2021

Conversation

synfinatic
Copy link
Owner

No need to require users to provide --use-sts as we should
automagically pull the necessary information from the shell
environment.

Add support for --prompt so you can always force using
the completer in the off-chance you want a console in a
different account/role.

Fixes: #169

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #173 (49f1a05) into main (5e79ffa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   43.96%   43.96%           
=======================================
  Files          10       10           
  Lines        1483     1483           
=======================================
  Hits          652      652           
  Misses        779      779           
  Partials       52       52           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e79ffa...49f1a05. Read the comment docs.

No need to require users to provide --use-sts as we should
automagically pull the necessary information from the shell
environment.

Add support for `--prompt` so you can always force using
the completer in the off-chance you want a console in a
different account/role.

Fixes: #169
@synfinatic synfinatic merged commit 11a4ba3 into main Dec 14, 2021
@synfinatic synfinatic deleted the use-sts branch December 14, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console --use-sts is already the default, why have a flag
1 participant