Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 #14

Merged
merged 1 commit into from
Feb 23, 2018
Merged

capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 #14

merged 1 commit into from
Feb 23, 2018

Conversation

wking
Copy link
Contributor

@wking wking commented Feb 20, 2018

The old methods had an internal Load(), which is unnecessary for some use cases. For example, if you're going to drop all capabilities, you don't need to load the current set first. This commit deprecates the old New* functions and adds New*2 functions which do not include the internal Load. Callers who do need the Load will need to call it explicitly after initializing their Capabilities object. Callers who do not need the Load can just add the 2 to the function name and get more efficient/robust behavior.

@wking wking force-pushed the new2-no-load branch 2 times, most recently from de16c6c to c9101b3 Compare February 20, 2018 00:19
@wking
capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
c9101b3 
The old methods had an internal Load(), which is unnecessary for some
use cases.  For example, if you're going to drop all capabilities, you
don't need to load the current set first.  This commit deprecates the
old New* functions and adds New*2 functions which do not include the
internal Load.  Callers who do need the Load will need to call it
explicitly after initializing their Capabilities object.  Callers who
do not need the Load can just add the "2" to the function name and get
more efficient/robust behavior.

The "Deprecated:" paragraph syntax is recommended in [1]:

  To signal that an identifier should not be used, add a paragraph to
  its doc comment that begins with "Deprecated:" followed by some
  information about the deprecation.

[1]: https://blog.golang.org/godoc-documenting-go-code
@wking
Copy link
Contributor Author

wking commented Feb 20, 2018

There is room for further optimization in this direction by adding a LoadType(which CapType) and/or teaching Get() to auto-load the requested type if it hadn't been loaded yet. I've left those off of this commit (folks can always add them later), but I'm happy to add them here if you'd like.

wking added a commit to wking/runc that referenced this pull request Feb 20, 2018
@wking
WIP: NewPid2
6579529 
Take advantage of [1] to avoid crashing with:

  container_linux.go:348: starting container process caused "open /proc/9976/status: no such file or directory"

[1]: syndtr/gocapability#14

Signed-off-by: W. Trevor King <[email protected]>
@wking wking mentioned this pull request Feb 20, 2018
Closed
@syndtr syndtr merged commit 33e07d3 into syndtr:master Feb 23, 2018
@wking wking mentioned this pull request Feb 23, 2018
Open
3 tasks
@wking wking deleted the new2-no-load branch February 23, 2018 05:41
thaJeztah added a commit to thaJeztah/runc that referenced this pull request Mar 28, 2019
@thaJeztah
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
f229e98 
relevant changes:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this pull request Mar 28, 2019
Merged
thaJeztah added a commit to thaJeztah/runc that referenced this pull request Mar 28, 2019
@thaJeztah
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
094daff 
relevant changes:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added a commit to thaJeztah/runc that referenced this pull request Apr 12, 2019
@thaJeztah
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
ae9f01b 
relevant changes:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added a commit to thaJeztah/runc that referenced this pull request Apr 12, 2019
@thaJeztah
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
4c784ec 
relevant changes:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added a commit to thaJeztah/runc that referenced this pull request Apr 12, 2019
@thaJeztah
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
122383d 
relevant changes:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this pull request Apr 17, 2019
Merged
thaJeztah added a commit to thaJeztah/containerd that referenced this pull request Apr 18, 2019
@thaJeztah
bump gocapability
0fd0256 
full diff: syndtr/gocapability@db04d3c...d983527

changes included:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
kiwik pushed a commit to theopenlab/containerd that referenced this pull request Apr 23, 2019
@Yikun @kiwik
Upstream sync (#2)
b6bc817 
* Add tcp service for grpc listeners

Signed-off-by: Michael Crosby <[email protected]>

* Set nofile to 1048576

Closes containerd#3201

Signed-off-by: Michael Crosby <[email protected]>

* Fix API forward events for shims

Signed-off-by: Michael Crosby <[email protected]>

* Add support for required plugins.

Signed-off-by: Lantao Liu <[email protected]>

* Use $TEST_RUNTIME for cri test.

Signed-off-by: Lantao Liu <[email protected]>

* Improve shim shutdown logic

Shims no longer call `os.Exit` but close the context on shutdown so that
events and other resources have hit the `defer`s.

Signed-off-by: Michael Crosby <[email protected]>

* Add dialer for events service

Signed-off-by: Michael Crosby <[email protected]>

* Rename `hrpc` to `tcpServer`

Signed-off-by: Michael Crosby <[email protected]>

* Check task list to avoid unnecessary cleanup.

Signed-off-by: Lantao Liu <[email protected]>

* Correct import path in services/server package

Signed-off-by: Jared Cordasco <[email protected]>

* Correct PusherFunc helper to match Pusher intf

Signed-off-by: Jared Cordasco <[email protected]>

* Requeue events in the shim publisher

Signed-off-by: Michael Crosby <[email protected]>

* bump mistifyio/go-zfs f784269be439d704d3dfa1906f45dd848fed2beb

- mistifyio/go-zfs#72 Switch to google/uuid
  - removes the github.com/pborman/uuid dependency

Signed-off-by: Sebastiaan van Stijn <[email protected]>

* Update go-winio in vendor.conf

Signed-off-by: Kevin Parsons <[email protected]>

* Allow dumping stacks via ETW capture state

Signed-off-by: Kevin Parsons <[email protected]>

* Access to client's GRPC connection object

Signed-off-by: Maksym Pavlenko <[email protected]>

* .mailmap: update Akihiro Suda's email address

No affiliation change (NTT).

The former email address will continue to be available for the time being.

For daily communication, I still prefer to use my gmail.com address.

Signed-off-by: Akihiro Suda <[email protected]>

* Move to sha-specified test image for nanoserver

Signed-off-by: Phil Estes <[email protected]>

* Fix error on pull hang in CI

Kill the underlying containerd after outputting error. Otherwise CI
hangs indefinitely and requires the CI infrastructure to kill the build
at the timeout expiration.

Signed-off-by: Wei Fu <[email protected]>
Signed-off-by: Phil Estes <[email protected]>

* Write stack dump to `os.TempDir()` as well

Signed-off-by: John Howard <[email protected]>

* bump gocapability

full diff: syndtr/gocapability@db04d3c...d983527

changes included:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>

* Update x/crypto to 88737f569e3a9c7ab309cdc09a07fe7fc87233c3

full diff: golang/crypto@4979611...88737f5

Signed-off-by: Sebastiaan van Stijn <[email protected]>

* bump containerd/console 0650fd9eeb50bab4fc99dceb9f2e14cf58f36e7f

Signed-off-by: Sebastiaan van Stijn <[email protected]>

* Convert Windows CI to use Microsoft MCR image urls

Signed-off-by: Justin Terry (VM) <[email protected]>

* Don't write dumped stacks to file for ETW capture state

Signed-off-by: Kevin Parsons <[email protected]>
thaJeztah added a commit to thaJeztah/runc that referenced this pull request Apr 25, 2019
@thaJeztah
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
74babe3 
relevant changes:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added a commit to thaJeztah/runc that referenced this pull request Jul 14, 2019
@thaJeztah
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
7163863 
relevant changes:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added a commit to thaJeztah/runc that referenced this pull request Aug 26, 2019
@thaJeztah
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
1110050 
relevant changes:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added a commit to thaJeztah/runc that referenced this pull request Sep 5, 2019
@thaJeztah
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
eb86f60 
relevant changes:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
stefanberger pushed a commit to stefanberger/runc that referenced this pull request Dec 31, 2019
@thaJeztah @stefanberger
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
32b4c88 
relevant changes:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
adrianreber pushed a commit to adrianreber/runc that referenced this pull request Feb 10, 2020
@thaJeztah @adrianreber
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
e7c4be9 
relevant changes:

  - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2
  - syndtr/gocapability#16 Fix capHeader.pid type

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wking @syndtr