Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency: Update to Electron 6 #148

Closed
dehmer opened this issue Oct 21, 2019 · 7 comments
Closed

Dependency: Update to Electron 6 #148

dehmer opened this issue Oct 21, 2019 · 7 comments
Labels
tech-debt technical debt back pay
Milestone

Comments

@dehmer
Copy link
Member

dehmer commented Oct 21, 2019

If there are no serious drawbacks we should update to Electron 6 to keep up to date.

@dehmer dehmer added tech-debt technical debt back pay target-0.5.0 labels Oct 21, 2019
@dehmer dehmer added this to the November - 2019 milestone Oct 21, 2019
@dehmer
Copy link
Member Author

dehmer commented Nov 1, 2019

Inconsistent and (now) invalid usage of ctor/ctor functions in TACGRP prevent upgrading electron/node.js.

@dehmer
Copy link
Member Author

dehmer commented Nov 2, 2019

One more reason to upgrade:
https://electronjs.org/blog/electron-7-0#end-of-support-for-4xy

@dehmer
Copy link
Member Author

dehmer commented Nov 4, 2019

Although Electron 7.0.1 was just released, we stick to 6.1.2 for now.

@dehmer
Copy link
Member Author

dehmer commented Nov 4, 2019

macOS build 6.1.2 crashed with

Exception Type:        EXC_BREAKPOINT (SIGTRAP)
Exception Codes:       0x0000000000000002, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Trace/BPT trap: 5
Termination Reason:    Namespace SIGNAL, Code 0x5
Terminating Process:   exc handler [3879]

see also: electron/electron#19626

@dehmer
Copy link
Member Author

dehmer commented Nov 4, 2019

Upgrading electron-builder should fix this problem: nklayman/vue-cli-plugin-electron-builder#390

@dehmer
Copy link
Member Author

dehmer commented Nov 4, 2019

Updating electron-builder to 22.1.0 resolves the crashing issue.
macOS build is good for Mojave and Catalina.

dehmer added a commit to dehmer/ODIN that referenced this issue Nov 4, 2019
@dehmer
Copy link
Member Author

dehmer commented Nov 4, 2019

Sadly, electron-builder update breaks Windows builds under macOS Mojave.
But since wine (32 bit) will not be supported for Catalina, we have to build under Windows anyways. Which, by the way, still works with version builder 22.1.0.

Reference: electron-userland/electron-builder#4336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt technical debt back pay
Projects
None yet
Development

No branches or pull requests

1 participant