-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scribe and Executor OmniRPC link fix #576
Conversation
Codecov ReportBase: 43.99364% // Head: 43.98995% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
===================================================
- Coverage 43.99364% 43.98995% -0.00369%
===================================================
Files 461 461
Lines 38992 38993 +1
Branches 180 180
===================================================
- Hits 17154 17153 -1
- Misses 19760 19762 +2
Partials 2078 2078
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Scribe and executor had the omnirpc link set to
omnirpc
rather thanscribe-omnirpc
orexecutor-omnirpc
respectively.