Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scribe and Executor OmniRPC link fix #576

Merged
merged 14 commits into from
Feb 21, 2023
Merged

Scribe and Executor OmniRPC link fix #576

merged 14 commits into from
Feb 21, 2023

Conversation

CryptoMaxPlanck
Copy link
Contributor

Description
Scribe and executor had the omnirpc link set to omnirpc rather than scribe-omnirpc or executor-omnirpc respectively.

@github-actions github-actions bot added the go Pull requests that update Go code label Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 43.99364% // Head: 43.98995% // Decreases project coverage by -0.00369% ⚠️

Coverage data is based on head (a4adafc) compared to base (4e9fa56).
Patch coverage: 100.00000% of modified lines in pull request are covered.

❗ Current head a4adafc differs from pull request most recent head 7709fed. Consider uploading reports for the commit 7709fed to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master        #576         +/-   ##
===================================================
- Coverage   43.99364%   43.98995%   -0.00369%     
===================================================
  Files            461         461                 
  Lines          38992       38993          +1     
  Branches         180         180                 
===================================================
- Hits           17154       17153          -1     
- Misses         19760       19762          +2     
  Partials        2078        2078                 
Flag Coverage Δ
explorer 44.29030% <ø> (-0.02072%) ⬇️
scribe 33.71991% <100.00000%> (+0.00582%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvices/scribe/db/datastore/sql/base/lastindexed.go 77.35849% <100.00000%> (+0.43541%) ⬆️
services/explorer/api/server.go 44.18605% <0.00000%> (-4.65116%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the M-ci Module: CI label Feb 21, 2023
@github-actions github-actions bot removed the M-ci Module: CI label Feb 21, 2023
Copy link
Contributor

@trajan0x trajan0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trajan0x trajan0x merged commit 0485546 into master Feb 21, 2023
@trajan0x trajan0x deleted the feat/helm-omnirpc-fix branch February 21, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code M-charts needs-go-generate-agents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants