Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(contracts-rfq): mark new methods as V2 #3410

Merged
merged 2 commits into from
Nov 25, 2024

refactor: update tests

209fbb1
Select commit
Loading
Failed to load commit list.
Merged

refactor(contracts-rfq): mark new methods as V2 #3410

refactor: update tests
209fbb1
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither completed Nov 25, 2024 in 4s

1 configuration not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 1 configuration present on refs/heads/master was not found:

Actions workflow (solidity.yml)

  • ❓  .github/workflows/solidity.yml:slither/package:contracts-core

New alerts in code changed by this pull request

Security Alerts:

  • 3 low

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 240 in packages/contracts-rfq/contracts/FastBridgeV2.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in FastBridgeV2.bridgeV2(IFastBridge.BridgeParams,IFastBridgeV2.BridgeParamsV2):
External calls:
- originAmount = _takeBridgedUserAsset(params.originToken,params.originAmount)
- returndata = address(token).functionCall(data)
- (success,returndata) = target.call{value: value}(data)
- IERC20(token).safeTransferFrom(msg.sender,address(this),amount)
External calls sending eth:
- originAmount = _takeBridgedUserAsset(params.originToken,params.originAmount)
- (success,returndata) = target.call{value: value}(data)
State variables written after the call(s):
- bridgeTxDetails[transactionId].status = BridgeStatus.REQUESTED
- bridgeTxDetails[transactionId].destChainId = params.dstChainId
- request = BridgeTransactionV2Lib.encodeV2(BridgeTransactionV2({originChainId:uint32(block.chainid),destChainId:params.dstChainId,originSender:params.sender,destRecipient:params.to,originToken:params.originToken,destToken:params.destToken,originAmount:originAmount,destAmount:params.destAmount,originFeeAmount:originFeeAmount,deadline:params.deadline,nonce:senderNonces[params.sender] ++,exclusivityRelayer:paramsV2.quoteRelayer,exclusivityEndTime:uint256(exclusivityEndTime),zapNative:paramsV2.zapNative,zapData:paramsV2.zapData}))

Check notice on line 240 in packages/contracts-rfq/contracts/FastBridgeV2.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in FastBridgeV2.bridgeV2(IFastBridge.BridgeParams,IFastBridgeV2.BridgeParamsV2):
External calls:
- originAmount = _takeBridgedUserAsset(params.originToken,params.originAmount)
- returndata = address(token).functionCall(data)
- (success,returndata) = target.call{value: value}(data)
- IERC20(token).safeTransferFrom(msg.sender,address(this),amount)
External calls sending eth:
- originAmount = _takeBridgedUserAsset(params.originToken,params.originAmount)
- (success,returndata) = target.call{value: value}(data)
Event emitted after the call(s):
- BridgeQuoteDetails(transactionId,paramsV2.quoteId)
- BridgeRequested({transactionId:transactionId,sender:params.sender,request:request,destChainId:params.dstChainId,originToken:params.originToken,destToken:params.destToken,originAmount:originAmount,destAmount:params.destAmount,sendChainGas:paramsV2.zapNative != 0})

Check notice on line 276 in packages/contracts-rfq/contracts/FastBridgeV2.sol

See this annotation in the file changed.

Code scanning / Slither

Block timestamp Low

FastBridgeV2.cancelV2(bytes) uses timestamp for comparisons
Dangerous comparisons:
- block.timestamp <= deadline