Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GET requests re CORS #3383

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Allow GET requests re CORS #3383

merged 1 commit into from
Nov 11, 2024

Conversation

abtestingalpha
Copy link
Collaborator

@abtestingalpha abtestingalpha commented Nov 11, 2024

Summary by CodeRabbit

  • New Features
    • Introduced CORS support to handle requests from different origins, enhancing compatibility with various client applications.

Copy link
Contributor

coderabbitai bot commented Nov 11, 2024

Walkthrough

The changes introduce a new middleware function to the Express application for handling Cross-Origin Resource Sharing (CORS). This middleware sets the necessary headers for incoming requests and responds with a 200 status for OPTIONS requests. The existing middleware for logging and request routing remains intact, ensuring that the application continues to function as before while incorporating CORS support.

Changes

File Path Change Summary
packages/rest-api/src/app.ts Added CORS middleware to handle Access-Control-Allow-* headers and respond to OPTIONS requests. Existing middleware remains unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant CORS Middleware
    participant Logging Middleware
    participant Request Handler

    Client->>CORS Middleware: Send Request
    CORS Middleware-->>Client: Set CORS Headers
    alt OPTIONS Request
        CORS Middleware-->>Client: Respond with 200
    else Other Request
        CORS Middleware->>Logging Middleware: Call next()
        Logging Middleware->>Request Handler: Process Request
        Request Handler-->>Logging Middleware: Send Response
        Logging Middleware-->>Client: Return Response
    end
Loading

Poem

🐇 In the meadow where bunnies play,
CORS has come to save the day!
With headers set and options clear,
Our requests can roam far and near.
So hop along, let’s celebrate,
Middleware magic, oh, isn’t it great! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.22600%. Comparing base (36efe55) to head (4a27a0a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #3383         +/-   ##
===================================================
+ Coverage   33.20876%   34.22600%   +1.01724%     
===================================================
  Files            544         524         -20     
  Lines          34786       33495       -1291     
  Branches          82          82                 
===================================================
- Hits           11552       11464         -88     
+ Misses         22216       21016       -1200     
+ Partials        1018        1015          -3     
Flag Coverage Δ
packages 90.44834% <ø> (ø)
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Nov 11, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4a27a0a
Status: ✅  Deploy successful!
Preview URL: https://57179d01.sanguine-fe.pages.dev
Branch Preview URL: https://rest-api-cors.sanguine-fe.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1d6280b and 4a27a0a.

📒 Files selected for processing (1)
  • packages/rest-api/src/app.ts (1 hunks)

@abtestingalpha abtestingalpha merged commit 7eda527 into master Nov 11, 2024
36 checks passed
@abtestingalpha abtestingalpha deleted the rest-api/cors branch November 11, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant