Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activeQuote depositAmount [SLT-464] #3372
activeQuote depositAmount [SLT-464] #3372
Changes from 1 commit
6808eb0
1908780
1e3bac6
77ffbd2
02e893b
1a32365
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 371 in services/rfq/relayer/quoter/quoter.go
Codecov / codecov/patch
services/rfq/relayer/quoter/quoter.go#L367-L371
Check warning on line 380 in services/rfq/relayer/quoter/quoter.go
Codecov / codecov/patch
services/rfq/relayer/quoter/quoter.go#L380
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: let's add a small comment explaining why this is
nil
.Check warning on line 787 in services/rfq/relayer/quoter/quoter.go
Codecov / codecov/patch
services/rfq/relayer/quoter/quoter.go#L779-L787
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add some cases for this in
TestGetOriginAmount