test(contracts-rfq): adjust setup to #3336 changes

[ChiTimesChi]

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

• Fixes #[Link to Issue]

Summary by CodeRabbit

• New Features

  • Updated the bridge transaction encoding process for improved data handling.

• Bug Fixes

  • Adjusted the function visibility for better state interaction management.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request modify the FastBridgeV2MulticallTargetTest contract within the FastBridgeV2.MulticallTarget.t.sol file. The visibility of the getEncodedBridgeTx function has been altered from view to pure, indicating that it no longer interacts with the blockchain state. Additionally, the assignment of bridgeTxV2.exclusivityEndTime to block.timestamp has been removed, impacting how the exclusivity end time is managed in the encoding process of bridge transactions.

Changes

File Path	Change Summary
packages/contracts-rfq/test/integration/FastBridgeV2.MulticallTarget.t.sol	- Changed getEncodedBridgeTx function visibility from view to pure. - Removed assignment of bridgeTxV2.exclusivityEndTime to block.timestamp.

Possibly related PRs

• feat(contracts-rfq): Multicall in FastBridgeV2 [SLT-369] #3315: This PR introduces multicall functionality in the FastBridgeV2 contract, which is relevant to the FastBridgeV2MulticallTargetTest contract in the main PR, as it also involves modifications to transaction handling.
• Parod/fb v2 multicall add test #3335: This PR enhances the testing framework for bridge transactions, including the handling of multiple actions, which aligns with the changes made in the main PR regarding the getEncodedBridgeTx function and its testing.

Suggested reviewers

• ChiTimesChi
• parodime

🐇 In the code we play,
With functions bright and pure,
The bridge now finds its way,
To handle data sure.
No more timestamps to bind,
Just clarity we seek,
In our tests, peace of mind! 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.