feat(contracts-rfq): FastBridge v1 multicall [SLT-324]

[ChiTimesChi]

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

• Fixes #[Link to Issue]

Summary by CodeRabbit

• New Features

  • Enhanced FastBridge contract to support multicall functionality through new inheritance.
  • Introduced a testing framework for FastBridge and MulticallTarget to validate functionalities and transaction behaviors.

• Bug Fixes

  • Improved reliability of bridge transaction processing through comprehensive testing scenarios.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The FastBridge contract has been modified to inherit from an additional contract, MulticallTarget, altering its inheritance hierarchy. This change introduces new functionalities related to multicall capabilities while maintaining existing logic for bridging transactions. Additionally, two new Solidity test files have been created to establish a testing framework for the FastBridge contract and its multicall functionalities, facilitating deployment and interaction in a controlled environment.

Changes

File Path	Change Summary
packages/contracts-rfq/contracts/FastBridge.sol	Updated contract inheritance to include MulticallTarget. Added import statement for MulticallTarget.
packages/contracts-rfq/test/integration/FastBridge.MulticallTarget.t.sol	Introduced FastBridgeMulticallTargetTest contract with methods for deploying and configuring FastBridge.
packages/contracts-rfq/test/integration/MulticallTarget.t.sol	Created abstract contract MulticallTargetIntegrationTest with multiple testing functions for multicall operations.

Possibly related PRs

• feat(contracts-rfq): Multicall target abstraction [SLT-134] #3078: Introduces the MulticallTarget contract, directly related to the changes in the FastBridge contract.
• feat(contracts-rfq): arbitrary call with value [SLT-233] [SLT-318] #3246: Enhances the FastBridgeV2 contract with a callValue parameter, relevant to the multicall capabilities.
• feat(contracts-rfq): add version to BridgeTransaction, tight packing [SLT-328] [SLT-273] #3284: Adds a version attribute to the BridgeTransaction, aligning with the changes in FastBridge.
• fix(contracts-rfq): add bridge/relay revert tests [SLT-322] #3251: Adds revert tests for the bridge and relay functions, directly related to the functionalities of the FastBridge contract.
• test(contracts-rfq): gas benchmark for the arbitrary call [SLT-233] #3273: Introduces gas benchmark tests for various functions related to bridge operations, including the newly modified FastBridge functionalities.

Suggested labels

size/l

Suggested reviewers

• ChiTimesChi
• trajan0x
• parodime

Poem

In the meadow where bridges sway,
Multicalls leap and dance all day.
FastBridge hops with a new-found grace,
Testing paths in a joyful race.
With every call, our dreams take flight,
Hopping high in the soft moonlight! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@e74153c). Learn more about missing BASE report.
Report is 87 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master       #3313   +/-   ##
============================================
  Coverage          ?   90.66667%           
============================================
  Files             ?          60           
  Lines             ?        1275           
  Branches          ?         155           
============================================
  Hits              ?        1156           
  Misses            ?         114           
  Partials          ?           5           

Flag	Coverage Δ
packages	90.50388% <ø> (?)
solidity	91.35802% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.