feat(promexporter): add some tracing #3114
Conversation
Deploying sanguine-fe with
|
| Latest commit: |
24e9f79
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5e420c51.sanguine-fe.pages.dev |
| Branch Preview URL: | https://promexporter-tracing.sanguine-fe.pages.dev |
WalkthroughThe pull request modifies the Changes
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3114 +/- ##
====================================================
- Coverage 90.56974% 43.76083% -46.80891%
====================================================
Files 54 74 +20
Lines 1018 2308 +1290
Branches 82 82
====================================================
+ Hits 922 1010 +88
- Misses 93 1292 +1199
- Partials 3 6 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- contrib/promexporter/exporters/exporter.go (4 hunks)
Additional comments not posted (4)
contrib/promexporter/exporters/exporter.go (4)
123-129: Improved context management and tracing.The changes to the
collectMetricsfunction signature and the addition of the tracing span enhance the context management and tracing capabilities of the function. ThecombineErrorsfunction is expected to aggregate errors collected during the function execution, providing clearer error reporting.These changes align with the PR objective of improving tracing and error handling.
133-133: Enhanced tracing with error-specific events.The addition of tracing events within the existing error handling blocks provides more granular insights into the function's execution flow. These events capture specific error occurrences related to fetching relayer balances and getting token balances, helping identify and diagnose issues more effectively.
The changes align with the PR objective of enhancing tracing capabilities.
Also applies to: 138-138
146-146: Enhanced tracing within loops.The addition of tracing events within the existing loops provides more granular insights into the function's execution flow. These events capture error occurrences related to getting stuck hero count, submitter stats, and vprice stats, helping identify and diagnose issues more effectively within the loops.
The changes align with the PR objective of enhancing tracing capabilities.
Also applies to: 155-155, 170-170
174-174: Improved error handling and reporting.The addition of the tracing event when metrics collection fails provides a high-level indication of the failure, complementing the more granular error events captured earlier in the function.
The introduction of the
combineErrorsfunction enhances the clarity of error reporting by consolidating multiple error messages into a single error. This makes it easier to understand the overall failure and aligns with the PR objective of improving error handling and reporting.The implementation of
combineErrorsis straightforward and effective, checking for the presence of errors in the input slice and joining their messages into a single string to create a new error with the combined message.Also applies to: 181-194
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit
New Features
Improvements