Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLT-152] feat(opbot): descending traces timestamp support #3092

Merged
merged 9 commits into from
Sep 17, 2024
Merged

[SLT-152] feat(opbot): descending traces timestamp support #3092

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
983dd48
descending timestamp support
golangisfun123 Sep 3, 2024
a25e2b5
better code
golangisfun123 Sep 3, 2024
b6472d7
Merge branch 'master' of github.com:synapsecns/sanguine into opbot-or…
golangisfun123 Sep 3, 2024
c64526f
Merge branch 'master' into opbot-orders
trajan0x Sep 10, 2024
15f48b2
fix order [goreleaser]
golangisfun123 Sep 10, 2024
b0337ac
Merge branch 'opbot-orders' of github.com:synapsecns/sanguine into op…
golangisfun123 Sep 10, 2024
3d6f64e
[goreleaser]
golangisfun123 Sep 10, 2024
b39d3d8
differnt delimiter [goreleaser]
golangisfun123 Sep 10, 2024
dbdd179
fix [goreleaser]
golangisfun123 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion contrib/opbot/botmd/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"log"
"math/big"
"regexp"
"sort"
"strings"
"sync"
"time"
Expand Down Expand Up @@ -50,7 +51,7 @@
// TODO: add trace middleware.
func (b *Bot) traceCommand() *slacker.CommandDefinition {
return b.requiresSignoz(&slacker.CommandDefinition{
Command: "trace <tags>",
Command: "trace <tags> <order>",

Check warning on line 54 in contrib/opbot/botmd/commands.go

View check run for this annotation

Codecov / codecov/patch

contrib/opbot/botmd/commands.go#L54 

Added line #L54 was not covered by tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The code change to introduce the <order> parameter is approved.

Consider adding test coverage.

The static analysis tool indicates that this line is not covered by tests.

Do you want me to generate test cases for this line or open a GitHub issue to track this task?

Tools
GitHub Check: codecov/patch

[warning] 54-54: contrib/opbot/botmd/commands.go#L54
Added line #L54 was not covered by tests

Description: "find a transaction in signoz",
Examples: []string{
"trace transaction_id:0x1234 serviceName:rfq",
Expand Down Expand Up @@ -105,6 +106,12 @@
}
return
}
isDescending := ctx.Request().Param("order") == "desc" || ctx.Request().Param("order") == "d"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The code change to introduce the isDescending variable is approved.

Consider adding test coverage.

The static analysis tool indicates that this line is not covered by tests.

Do you want me to generate test cases for this line or open a GitHub issue to track this task?

Tools
GitHub Check: codecov/patch

[warning] 109-113: contrib/opbot/botmd/commands.go#L109-L113
Added lines #L109 - L113 were not covered by tests

if isDescending {
sort.Slice(traceList, func(i, j int) bool {
return traceList[i].Timestamp.After(traceList[j].Timestamp)
})

Check warning on line 113 in contrib/opbot/botmd/commands.go

View check run for this annotation

Codecov / codecov/patch

contrib/opbot/botmd/commands.go#L109-L113 

Added lines #L109 - L113 were not covered by tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The code changes to sort the traceList in descending order are approved.

Consider adding test coverage.

The static analysis tool indicates that these lines are not covered by tests.

Do you want me to generate test cases for these lines or open a GitHub issue to track this task?

Tools
GitHub Check: codecov/patch

[warning] 109-113: contrib/opbot/botmd/commands.go#L109-L113
Added lines #L109 - L113 were not covered by tests

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The code changes to sort the traceList in descending order are approved.

Consider adding test coverage.

The static analysis tool indicates that these lines are not covered by tests.

Do you want me to generate test cases for these lines or open a GitHub issue to track this task?

Tools
GitHub Check: codecov/patch

[warning] 112-115: contrib/opbot/botmd/commands.go#L112-L115
Added lines #L112 - L115 were not covered by tests


slackBlocks := []slack.Block{slack.NewHeaderBlock(slack.NewTextBlockObject(slack.PlainTextType, fmt.Sprintf("Traces for %s", tags), false, false))}

Expand Down
Loading