feat(promexporter): relayer balances #3016
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| package exporters | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
| "io" | ||
| "math/big" | ||
| "net/http" | ||
| "slices" | ||
|
|
||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/ethereum/go-ethereum/params" | ||
| "github.com/lmittmann/w3/module/eth" | ||
| "github.com/lmittmann/w3/w3types" | ||
| rfqAPIModel "github.com/synapsecns/sanguine/services/rfq/api/model" | ||
| ) | ||
|
|
||
| func (e *exporter) fetchRelayerBalances(ctx context.Context, url string) error { | ||
| // Fetch relayer addresses | ||
| quotes, err := e.fetchAllQuotes(ctx, url) | ||
| if err != nil { | ||
| return fmt.Errorf("could not fetch relayer addresses: %w", err) | ||
| } | ||
|
Comment on lines
+19
to
+24
There was a problem hiding this comment. Consider adding test coverage for The function Would you like assistance in creating tests for this function? ToolsGitHub Check: codecov/patch
|
||
|
|
||
| // chainIDs is a map of chain ID to relayer addresses | ||
| chainIDToRelayers := make(map[int][]string) | ||
|
|
||
| // Get all chain IDs | ||
| for _, quote := range quotes { | ||
| if !slices.Contains(chainIDToRelayers[quote.OriginChainID], quote.RelayerAddr) { | ||
| chainIDToRelayers[quote.OriginChainID] = append(chainIDToRelayers[quote.OriginChainID], quote.RelayerAddr) | ||
| } | ||
|
|
||
| if !slices.Contains(chainIDToRelayers[quote.DestChainID], quote.RelayerAddr) { | ||
| chainIDToRelayers[quote.DestChainID] = append(chainIDToRelayers[quote.DestChainID], quote.RelayerAddr) | ||
| } | ||
| } | ||
|
|
||
| for chainID, relayers := range chainIDToRelayers { | ||
| client, err := e.omnirpcClient.GetConfirmationsClient(ctx, chainID, 1) | ||
| if err != nil { | ||
| return fmt.Errorf("could not get confirmations client: %w", err) | ||
| } | ||
|
|
||
| var relayerBalances []*big.Int | ||
| for range relayers { | ||
| relayerBalances = append(relayerBalances, new(big.Int)) | ||
| } | ||
|
|
||
| var callsForCurrentChainID []w3types.Caller | ||
| for i, relayer := range relayers { | ||
| callsForCurrentChainID = append( | ||
| callsForCurrentChainID, | ||
| eth.Balance(common.HexToAddress(relayer), nil).Returns(relayerBalances[i]), | ||
| ) | ||
| } | ||
|
|
||
| _ = e.batchCalls(ctx, client, callsForCurrentChainID) | ||
|
There was a problem hiding this comment. logic: Ignoring the error returned by e.batchCalls may lead to silent failures. Consider handling or logging this error. |
||
|
|
||
| for i, balanceOfRelayer := range relayerBalances { | ||
| balanceFloat, _ := new(big.Float).SetInt(balanceOfRelayer).Float64() | ||
| relayerMetadata := relayerMetadata{ | ||
| address: common.HexToAddress(relayers[i]), | ||
| balance: balanceFloat / params.Ether, | ||
| } | ||
| // the line of interest, where we record each relayer data for the respective chainID | ||
| e.otelRecorder.RecordRelayerBalance(chainID, relayerMetadata) | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (e *exporter) fetchAllQuotes(ctx context.Context, url string) ([]rfqAPIModel.GetQuoteResponse, error) { | ||
| req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("could not get quotes: %w", err) | ||
| } | ||
|
|
||
| res, err := e.client.Do(req) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("could not get quotes: %w", err) | ||
| } | ||
| defer func() { | ||
| _ = res.Body.Close() | ||
| }() | ||
|
Comment on lines
+85
to
+87
There was a problem hiding this comment. style: Consider using |
||
|
|
||
| body, err := io.ReadAll(res.Body) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("could not read body: %w", err) | ||
| } | ||
|
|
||
| var quotes []rfqAPIModel.GetQuoteResponse | ||
| err = json.Unmarshal(body, "es) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("could not unmarshal quotes: %w", err) | ||
| } | ||
|
|
||
| return quotes, nil | ||
| } | ||
|
Comment on lines
+75
to
+101
There was a problem hiding this comment. Consider adding test coverage for The function Would you like assistance in creating tests for this function? ToolsGitHub Check: codecov/patch
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure test coverage for new error handling logic.
The error handling logic for fetching relayer balances in
collectMetricslacks test coverage. Consider adding tests to verify its behavior under different scenarios.Would you like assistance in creating tests for this error handling logic?
Tools
GitHub Check: codecov/patch