Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solidity pragmas #294

Merged
merged 6 commits into from
Oct 23, 2022
Merged

Update solidity pragmas #294

merged 6 commits into from
Oct 23, 2022

Conversation

ChiTimesChi
Copy link
Collaborator

Description

This PR aims to use the most recent version of Solidity compiler at the time of opening this PR: 0.8.17.

Previously used version 0.8.13 had a critical bug, described here. One of the side effects present in the test suite was that abi.encode(bytes) would return different values depending on whether the bytes array was in storage or not.

@github-actions github-actions bot added 2-reviewers C-Protocol-Critical PRs that modify protocol-critical code. go Pull requests that update Go code M-contracts Module: Contracts labels Oct 22, 2022
@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Base: 34.77569% // Head: 34.81162% // Increases project coverage by +0.03593% 🎉

Coverage data is based on head (92e0ab2) compared to base (eb25c55).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master        #294         +/-   ##
===================================================
+ Coverage   34.77569%   34.81162%   +0.03593%     
===================================================
  Files            375         375                 
  Lines          38964       38964                 
  Branches          85          85                 
===================================================
+ Hits           13550       13564         +14     
+ Misses         23673       23662         -11     
+ Partials        1741        1738          -3     
Impacted Files Coverage Δ
.../contracts-core/contracts/AttestationCollector.sol 97.50000% <ø> (ø)
packages/contracts-core/contracts/Destination.sol 76.66667% <ø> (ø)
...ackages/contracts-core/contracts/NotaryManager.sol 87.50000% <ø> (ø)
packages/contracts-core/contracts/Origin.sol 85.18519% <ø> (ø)
...es/contracts-core/contracts/client/BasicClient.sol 100.00000% <ø> (ø)
...ackages/contracts-core/contracts/client/Client.sol 100.00000% <ø> (ø)
.../contracts-core/contracts/client/SynapseClient.sol 100.00000% <ø> (ø)
...core/contracts/client/SynapseClientUpgradeable.sol 90.90909% <ø> (ø)
...contracts-core/contracts/context/DomainContext.sol 100.00000% <ø> (ø)
...acts-core/contracts/context/LocalDomainContext.sol 100.00000% <ø> (ø)
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@trajan0x trajan0x merged commit 92d713c into master Oct 23, 2022
@trajan0x trajan0x deleted the fix/solidity-pragmas branch October 23, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-reviewers C-Protocol-Critical PRs that modify protocol-critical code. go Pull requests that update Go code M-contracts Module: Contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants