Updates Linea svg in synapse constants #2928
Conversation
Defi-Moses
requested review from
trajan0x,
bigboydiamonds and
abtestingalpha
as code owners
github-actions
bot
added
javascript
WalkthroughThis update enhances the application by integrating the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant GraphQL
participant DB
User->>UI: Request Daily Stats
UI->>GraphQL: Query GetDailyStatisticsByChain
GraphQL->>DB: Fetch Data (base, blast, scroll, linea)
DB-->>GraphQL: Return Data
GraphQL-->>UI: Return Stats
UI-->>User: Display Stats
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Deploying sanguine-fe with
|
| Latest commit: |
4bf3720
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9da33df4.sanguine-fe.pages.dev |
| Branch Preview URL: | https://explorer-adding-new-chains.sanguine-fe.pages.dev |
github-actions
bot
added
size/xs
and removed
M-explorer-ui
Sol
Typescript
size/m
labels
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Inline review comments failed to post
Actionable comments posted: 4
Outside diff range, codebase verification and nitpick comments (1)
packages/synapse-constants/scripts/generateMaps.js (1)
3-4: Update the import paths to the correct locations.The following files exist in the repository but are not in the paths specified in the import statements. Here are the correct paths:
./utils/prettyPrintTsshould be./utils/prettyPrintTs.js./utils/fetchRfqDatashould be./utils/fetchRfqData.js./data/providers.jsonis correct./data/ignoredBridgeSymbols.jsonis correct./data/symbolOverrides.jsonis correct./abi/SynapseRouter.jsonis correct./abi/SynapseCCTP.jsonis correct./abi/SynapseCCTPRouter.jsonis correct./abi/SwapQuoter.jsonis correct./abi/IERC20Metadata.jsonis correct./abi/IDefaultPool.jsonis correctPlease update the import statements to reflect these correct paths.
Analysis chain
Verify the correctness of the new import paths.
The import paths have been modified to stay within the same directory. Ensure that these paths are correct and that the files exist in the specified locations.
Also applies to: 6-6, 8-8, 10-10, 12-17
The specified import paths are incorrect or the files are missing from the repository.
The following files were not found in the specified paths:
./utils/prettyPrintTs./utils/fetchRfqData./data/providers.json./data/ignoredBridgeSymbols.json./data/symbolOverrides.json./abi/SynapseRouter.json./abi/SynapseCCTP.json./abi/SynapseCCTPRouter.json./abi/SwapQuoter.json./abi/IERC20Metadata.json./abi/IDefaultPool.jsonPlease verify if these files exist in the repository and update the import paths accordingly.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the imported files in the specified paths. # Test: Check if the files exist. Expect: All files should exist. for file in ./utils/prettyPrintTs ./utils/fetchRfqData ./data/providers.json ./data/ignoredBridgeSymbols.json ./data/symbolOverrides.json ./abi/SynapseRouter.json ./abi/SynapseCCTP.json ./abi/SynapseCCTPRouter.json ./abi/SwapQuoter.json ./abi/IERC20Metadata.json ./abi/IDefaultPool.json; do if [ ! -f "$file" ]; then echo "File not found: $file" fi doneLength of output: 4641
Script:
#!/bin/bash # Description: Search for the existence of the specified files in the repository. # List of files to search for files=( "prettyPrintTs" "fetchRfqData" "providers.json" "ignoredBridgeSymbols.json" "symbolOverrides.json" "SynapseRouter.json" "SynapseCCTP.json" "SynapseCCTPRouter.json" "SwapQuoter.json" "IERC20Metadata.json" "IDefaultPool.json" ) # Search for each file in the repository for file in "${files[@]}"; do echo "Searching for: $file" fd "$file" doneLength of output: 3062
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (2)
packages/synapse-constants/constants/assets/chains/linea.svgis excluded by!**/*.svgpackages/synapse-constants/constants/assets/explorer/linea.svgis excluded by!**/*.svg
Files selected for processing (22)
- packages/explorer-ui/components/ChainChart/index.tsx (1 hunks)
- packages/explorer-ui/graphql/queries/index.ts (1 hunks)
- packages/synapse-constants/constants/assets/chains/index.ts (1 hunks)
- packages/synapse-constants/constants/assets/explorer/index.ts (1 hunks)
- packages/synapse-constants/constants/bridgeMap.ts (38 hunks)
- packages/synapse-constants/constants/chains/index.ts (2 hunks)
- packages/synapse-constants/constants/chains/master.ts (3 hunks)
- packages/synapse-constants/constants/tokens/bridgeMap.ts (39 hunks)
- packages/synapse-constants/constants/tokens/bridgeable.ts (5 hunks)
- packages/synapse-constants/constants/tokens/deprecated.ts (1 hunks)
- packages/synapse-constants/constants/tokens/swapMaster.ts (1 hunks)
- packages/synapse-constants/scripts/generateMaps.js (9 hunks)
- packages/synapse-constants/scripts/utils/fetchRfqData.js (1 hunks)
- packages/synapse-constants/scripts/utils/prettyPrintTs.js (1 hunks)
- services/explorer/api/server_test.go (1 hunks)
- services/explorer/graphql/client/client.go (2 hunks)
- services/explorer/graphql/client/queries/queries.graphql (1 hunks)
- services/explorer/graphql/server/graph/model/models_gen.go (1 hunks)
- services/explorer/graphql/server/graph/partials.go (6 hunks)
- services/explorer/graphql/server/graph/resolver/server.go (6 hunks)
- services/explorer/graphql/server/graph/schema/types.graphql (1 hunks)
- services/explorer/static/chainIDs.yaml (1 hunks)
Files skipped from review due to trivial changes (5)
- packages/synapse-constants/constants/assets/chains/index.ts
- packages/synapse-constants/constants/assets/explorer/index.ts
- packages/synapse-constants/constants/tokens/deprecated.ts
- packages/synapse-constants/constants/tokens/swapMaster.ts
- services/explorer/static/chainIDs.yaml
Additional comments not posted (53)
packages/explorer-ui/graphql/queries/index.ts (1)
213-213: LGTM! The addition of thelineafield is correct.The
lineafield has been correctly added to theDAILY_STATISTICS_BY_CHAINquery.services/explorer/graphql/server/graph/schema/types.graphql (1)
182-182: Addition oflineafield looks good.The new field
lineais consistent with the existing fields in theDateResultByChaintype and is appropriately typed asFloat.packages/synapse-constants/constants/chains/index.ts (2)
78-78: Addition ofLINEAentry inChainIdlooks good.The new entry
LINEAwith the value59144is consistent with the existing entries in theChainIdmapping.
128-130: Additions toFASTBRIDGE_CONTRACTSlook good.The new entries for
ChainId.LINEA,ChainId.BLAST, andChainId.BSCare consistent with the existing entries and the addresses are correctly formatted.services/explorer/api/server_test.go (1)
60-60: Addition ofLineafield in the test struct looks good.The new field
Lineais consistent with the existing fields and is appropriately typed as a pointer tofloat64with JSON and GraphQL tags for serialization.services/explorer/graphql/client/queries/queries.graphql (1)
157-157: LGTM! Thelineafield addition is correct.The addition of the
lineafield to theGetDailyStatisticsByChainquery is consistent with the existing fields and follows the correct pattern.packages/explorer-ui/components/ChainChart/index.tsx (1)
317-322: LGTM! The<Bar>component forlineais correctly added.The addition of the new
<Bar>component for thelineadata series is consistent with the existing<Bar>components and follows the correct pattern.packages/synapse-constants/constants/chains/master.ts (3)
22-22: LGTM! The import statement forlineaImgis correct.The import statement for the
lineaImgasset is correctly added.
44-44: LGTM! The import statement forlineaExplorerImgis correct.The import statement for the
lineaExplorerImgasset is correctly added.
484-506: LGTM! TheLINEAentity is correctly added.The addition of the
LINEAentity is comprehensive and follows the same pattern as the other blockchain entities. It includes all necessary properties.packages/synapse-constants/scripts/generateMaps.js (4)
33-37: Verify the correctness and usage of new constants.The new constants
allowedChainIdsForSynapseBridgeandallowedChainIdsForRfqhave been introduced. Ensure that these constants are correctly defined and used appropriately in the code.Also applies to: 42-43
Verification successful
The new constants are correctly defined and used appropriately in the codebase.
The constants
allowedChainIdsForSynapseBridgeandallowedChainIdsForRfqare defined and used consistently in bothpackages/synapse-constants/scripts/generateMaps.jsandpackages/synapse-interface/scripts/generateMaps.js.
allowedChainIdsForSynapseBridgeis used inforEachloops.allowedChainIdsForRfqis used inincludeschecks.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the new constants in the codebase. # Test: Search for the usage of the constants. Expect: Constants should be used in appropriate places. rg --type js 'allowedChainIdsForSynapseBridge' rg --type js 'allowedChainIdsForRfq'Length of output: 1167
462-463: Ensure correctness of the new function logic.The function
getRFQSymbolhas been introduced to generate RFQ symbols. Ensure that the function logic is correct and follows best practices.Verification successful
Ensure correctness of the new function logic.
The function
getRFQSymbolhas been introduced to generate RFQ symbols by concatenating "RFQ." with the provided symbol. The logic is straightforward and appears to be correctly implemented in bothpackages/synapse-constants/scripts/generateMaps.jsandpackages/synapse-interface/scripts/generateMaps.js.
packages/synapse-constants/scripts/generateMaps.jspackages/synapse-interface/scripts/generateMaps.jsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new function logic in the `getRFQSymbol` function. # Test: Search for the function definition and its usage. Expect: Function logic should be correctly implemented. rg --type js 'const getRFQSymbol' rg --type js 'getRFQSymbol'Length of output: 649
81-86: Ensure correctness and performance of the updated function logic.The function
getBridgeOriginMaphas been updated to return early for chains without a correspondingSwapQuoter. Ensure that this logic is correct and optimizes performance by preventing unnecessary processing.Verification successful
The early return logic in the
getBridgeOriginMapfunction is correctly implemented and optimizes performance by preventing unnecessary processing.
- The function returns early if there is no
SwapQuoterfor the givenchainId, ensuring efficient execution.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the early return logic in the `getBridgeOriginMap` function. # Test: Search for the function definition and its usage. Expect: Early return logic should be correctly implemented. rg --type js 'const getBridgeOriginMap' rg --type js 'getBridgeOriginMap'Length of output: 717
Script:
#!/bin/bash # Extract the full implementation of `getBridgeOriginMap` from both files. # Extract from packages/synapse-constants/scripts/generateMaps.js ast-grep --lang javascript --pattern $'const getBridgeOriginMap = async (chainId) => { $$$ }' packages/synapse-constants/scripts/generateMaps.js # Extract from packages/synapse-interface/scripts/generateMaps.js ast-grep --lang javascript --pattern $'const getBridgeOriginMap = async (chainId) => { $$$ }' packages/synapse-interface/scripts/generateMaps.jsLength of output: 12657
Line range hint
277-297:
Ensure correctness and integration of new RFQ data handling logic.The function
printMapshas been expanded to handle RFQ data. Ensure that the new logic is correct and integrates well with the existing code.Also applies to: 312-369
Verification successful
The new RFQ data handling logic in the
printMapsfunction is correctly implemented and well-integrated with the existing code.
- The function correctly checks for allowed chain IDs and adds RFQ symbols to the origin and destination lists.
- The RFQ responses are processed and integrated into the existing token maps.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new RFQ data handling logic in the `printMaps` function. # Test: Search for the function definition and its usage. Expect: RFQ data handling logic should be correctly implemented. rg --type js 'const printMaps' rg --type js 'printMaps'Length of output: 515
Script:
#!/bin/bash # Extract the implementation of the `printMaps` function from both files for comparison and review. # Extract from `packages/synapse-constants/scripts/generateMaps.js` rg --type js -A 50 'const printMaps = async () => {' packages/synapse-constants/scripts/generateMaps.js # Extract from `packages/synapse-interface/scripts/generateMaps.js` rg --type js -A 50 'const printMaps = async () => {' packages/synapse-interface/scripts/generateMaps.jsLength of output: 463
Script:
#!/bin/bash # Extract the implementation of the `printMaps` function from both files for comparison and review. # Extract from `packages/synapse-constants/scripts/generateMaps.js` rg --type js -A 50 'const printMaps = async () =>' packages/synapse-constants/scripts/generateMaps.js # Extract from `packages/synapse-interface/scripts/generateMaps.js` rg --type js -A 50 'const printMaps = async () =>' packages/synapse-interface/scripts/generateMaps.jsLength of output: 207
Script:
#!/bin/bash # Extract the implementation of the `printMaps` function from both files for comparison and review. # Extract from `packages/synapse-constants/scripts/generateMaps.js` rg --type js -A 100 'printMaps' packages/synapse-constants/scripts/generateMaps.js # Extract from `packages/synapse-interface/scripts/generateMaps.js` rg --type js -A 100 'printMaps' packages/synapse-interface/scripts/generateMaps.jsLength of output: 7669
services/explorer/graphql/server/graph/model/models_gen.go (1)
106-106: Ensure correctness and integration of the new field.The new field
Lineahas been added to theDateResultByChainstruct. Ensure that the field is correctly defined and integrates well with the existing code.Verification successful
Ensure the new field
Lineais correctly integrated and used.The new field
Lineahas been added to theDateResultByChainstruct. We need to verify its usage and integration in the codebase.
The new field
Lineais correctly defined and integrated.The field
Lineahas been added to theDateResultByChainstruct and is correctly utilized in the codebase, including JSON and GraphQL contexts, as well as in resolver logic.
services/explorer/graphql/client/client.goservices/explorer/graphql/server/graph/model/models_gen.goservices/explorer/graphql/server/graph/resolver/server.goservices/explorer/api/server_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new field in the `DateResultByChain` struct. # Test: Search for the struct definition and its usage. Expect: Field should be correctly implemented. rg --type go 'type DateResultByChain struct' rg --type go 'DateResultByChain'Length of output: 35107
Script:
#!/bin/bash # Description: Verify the usage of the new field `Linea` in the codebase. # Test: Search for the term `Linea` to check its usage. rg --type go 'Linea'Length of output: 735
services/explorer/graphql/client/client.go (2)
504-504: Ensure correctness and integration of the query updates.The query
GetDailyStatisticsByChainDocumenthas been updated to include thelineafield. Ensure that the query updates are correctly defined and integrate well with the existing code.Verification successful
The
lineafield has been correctly defined and integrated into theGetDailyStatisticsByChainDocumentquery and the rest of the codebase.
services/explorer/graphql/client/client.go: Thelineafield is defined and included in the query.services/explorer/graphql/server/graph/partials.go: Thelineafield is used in query results.services/explorer/graphql/server/graph/model/models_gen.go: Thelineafield is included in the model.services/explorer/graphql/server/graph/resolver/server.go: Thelineafield is handled in the resolver.services/explorer/api/server_test.go: Thelineafield is included in the tests.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the query updates in the `GetDailyStatisticsByChainDocument`. # Test: Search for the query definition and its usage. Expect: Query updates should be correctly implemented. rg --type go 'const GetDailyStatisticsByChainDocument' rg --type go 'GetDailyStatisticsByChainDocument'Length of output: 735
Script:
#!/bin/bash # Description: Verify the inclusion and usage of the `linea` field in the `GetDailyStatisticsByChainDocument` query. # Test: Search for the `linea` field within the `GetDailyStatisticsByChainDocument` query definition. rg --type go 'linea' services/explorer/graphql/client/client.go # Test: Search for the usage of the `linea` field in the codebase. rg --type go 'linea'Length of output: 2170
131-131: Ensure correctness and integration of the new field.The new field
Lineahas been added to theGetDailyStatisticsByChainstruct. Ensure that the field is correctly defined and integrates well with the existing code.Verification successful
Ensure correctness and integration of the new field.
The new field
Lineahas been added to theGetDailyStatisticsByChainstruct. Ensure that the field is correctly defined and integrates well with the existing code.
- Verify the struct definition in
services/explorer/graphql/client/client.go.- Check the usage instances in the same file and other files to confirm proper integration.
Ensure correctness and integration of the new field.
The new field
Lineahas been added to theGetDailyStatisticsByChainstruct. Ensure that the field is correctly defined and integrates well with the existing code.
- Verify the presence and correct definition of the
Lineafield in theGetDailyStatisticsByChainstruct.- Check the usage instances in the same file and other files to confirm proper integration.
Ensure correctness and integration of the new field.
The new field
Lineahas been correctly added to theGetDailyStatisticsByChainstruct and is integrated into the existing codebase.
- The
Lineafield is defined in theGetDailyStatisticsByChainstruct inservices/explorer/graphql/client/client.go.- The
Lineafield is also referenced in test files and other related model and resolver files, indicating proper integration.The field
Lineaappears to be correctly implemented and integrated.
services/explorer/graphql/client/client.goservices/explorer/api/server_test.goservices/explorer/graphql/server/graph/model/models_gen.goservices/explorer/graphql/server/graph/resolver/server.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new field in the `GetDailyStatisticsByChain` struct. # Test: Search for the struct definition and its usage. Expect: Field should be correctly implemented. rg --type go 'type GetDailyStatisticsByChain struct' rg --type go 'GetDailyStatisticsByChain'Length of output: 8681
Script:
#!/bin/bash # Description: Verify the new field in the `GetDailyStatisticsByChain` struct. # Test: Search for the struct definition and its usage. Expect: Field should be correctly implemented. rg --type go 'type GetDailyStatisticsByChain struct' -A 10 rg --type go 'GetDailyStatisticsByChain' -A 10Length of output: 40315
Script:
#!/bin/bash # Description: Verify the new field in the `GetDailyStatisticsByChain` struct. # Test: Search for the specific field `Linea` in the struct definition. Expect: Field should be correctly implemented. rg --type go 'Linea' -A 5 -B 5Length of output: 6137
services/explorer/graphql/server/graph/partials.go (6)
403-403: LGTM!The addition of the
lineafield to thedailyVolumeBridgeMvPt1query is consistent with the existing fields.
447-447: LGTM!The addition of the
lineafield to thedailyVolumeBridgequery is consistent with the existing fields.
543-543: LGTM!The addition of the
lineafield to thedailyStatisticGenericSelectquery is consistent with the existing fields.
645-645: LGTM!The addition of the
lineafield to thedailyStatisticGenericSinglePlatformquery is consistent with the existing fields.
676-676: LGTM!The addition of the
lineafield to thedailyStatisticGenericSinglePlatformMvquery is consistent with the existing fields.
708-708: LGTM!The addition of the
lineafield to thedailyStatisticGenericSinglePlatformMvFeequery is consistent with the existing fields.packages/synapse-constants/constants/tokens/bridgeable.ts (3)
415-415: LGTM!The addition of the
LINEAchain entry to theUSDCtoken definition is consistent with the existing entries.
492-492: LGTM!The addition of the
SCROLLchain entry to theUSDTtoken definition is consistent with the existing entries.
792-792: LGTM!The addition of the
LINEAchain entry to theETHtoken definition is consistent with the existing entries.packages/synapse-constants/constants/bridgeMap.ts (10)
34-42: Approved: Addition ofRFQ.USDCtonUSDorigin array.The addition of
RFQ.USDCto theoriginarray fornUSDis consistent with the PR objective of integrating RFQ mechanisms.
71-79: Approved: Addition ofRFQ.USDCtoLUSDorigin array.The addition of
RFQ.USDCto theoriginarray forLUSDis consistent with the PR objective of integrating RFQ mechanisms.
101-109: Approved: Addition ofRFQ.USDCtoDAIorigin array.The addition of
RFQ.USDCto theoriginarray forDAIis consistent with the PR objective of integrating RFQ mechanisms.
124-132: Approved: Addition ofRFQ.USDCtoPYUSDorigin array.The addition of
RFQ.USDCto theoriginarray forPYUSDis consistent with the PR objective of integrating RFQ mechanisms.
161-169: Approved: Addition ofRFQ.USDCtoFRAXorigin array.The addition of
RFQ.USDCto theoriginarray forFRAXis consistent with the PR objective of integrating RFQ mechanisms.
191-200: Approved: Addition ofRFQ.USDCtoUSDCorigin and destination arrays.The addition of
RFQ.USDCto theoriginanddestinationarrays forUSDCis consistent with the PR objective of integrating RFQ mechanisms.
235-235: Approved: Addition ofRFQ.ETHtoWETHorigin array.The addition of
RFQ.ETHto theoriginarray forWETHis consistent with the PR objective of integrating RFQ mechanisms.
242-243: Approved: Addition ofRFQ.ETHtoETHorigin and destination arrays.The addition of
RFQ.ETHto theoriginanddestinationarrays forETHis consistent with the PR objective of integrating RFQ mechanisms.
256-264: Approved: Addition ofRFQ.USDCtoUSDTorigin array.The addition of
RFQ.USDCto theoriginarray forUSDTis consistent with the PR objective of integrating RFQ mechanisms.
311-312: Approved: Addition ofRFQ.USDCtoUSDCorigin array on chain10.The addition of
RFQ.USDCto theoriginarray forUSDCon chain10is consistent with the PR objective of integrating RFQ mechanisms.packages/synapse-constants/constants/tokens/bridgeMap.ts (11)
34-42: LGTM! The inclusion ofRFQ.USDCenhances liquidity and trading routes.The addition of
RFQ.USDCto theoriginfield for the token0x1B84765dE8B7566e4cEAF4D0fD3c5aF52D3DdE4Fis a beneficial change.
71-79: LGTM! The inclusion ofRFQ.USDCenhances liquidity and trading routes.The addition of
RFQ.USDCto theoriginfield for the token0x5f98805A4E8be255a32880FDeC7F6728C6568bA0is a beneficial change.
101-109: LGTM! The inclusion ofRFQ.USDCenhances liquidity and trading routes.The addition of
RFQ.USDCto theoriginfield for the token0x6B175474E89094C44Da98b954EedeAC495271d0Fis a beneficial change.
124-132: LGTM! The inclusion ofRFQ.USDCenhances liquidity and trading routes.The addition of
RFQ.USDCto theoriginfield for the token0x6c3ea9036406852006290770BEdFcAbA0e23A0e8is a beneficial change.
161-169: LGTM! The inclusion ofRFQ.USDCenhances liquidity and trading routes.The addition of
RFQ.USDCto theoriginfield for the token0x853d955aCEf822Db058eb8505911ED77F175b99eis a beneficial change.
191-200: LGTM! The inclusion ofRFQ.USDCenhances liquidity and trading routes.The addition of
RFQ.USDCto theoriginanddestinationfields for the token0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48is a beneficial change.
256-264: LGTM! The inclusion ofRFQ.USDCenhances liquidity and trading routes.The addition of
RFQ.USDCto theoriginfield for the token0xdAC17F958D2ee523a2206206994597C13D831ec7is a beneficial change.
286-294: LGTM! The inclusion ofRFQ.USDCenhances liquidity and trading routes.The addition of
RFQ.USDCto theoriginfield for the token0xf939E0A03FB07F59A73314E73794Be0E57ac1b4Eis a beneficial change.
311-312: LGTM! The inclusion ofRFQ.USDCenhances liquidity and trading routes.The addition of
RFQ.USDCto theoriginanddestinationfields for the token0x0b2C639c533813f4Aa9D7837CAf62653d097Ff85is a beneficial change.
355-355: LGTM! The inclusion ofRFQ.USDCenhances liquidity and trading routes.The addition of
RFQ.USDCto theoriginfield for the token0x67C10C397dD0Ba417329543c1a40eb48AAa7cd00is a beneficial change.
218-224: LGTM! The addition of the new token entry is a beneficial enhancement.The new entry for the token
0xAdF7C35560035944e805D98fF17d58CDe2449389withorigin,destination, andswappablefields expands the bridge's capabilities.services/explorer/graphql/server/graph/resolver/server.go (6)
119-119: LGTM!The addition of the
Lineafunction to theComplexityRootstruct is consistent with the existing fields.
607-613: LGTM!The addition of the
lineacase in the complexity calculation logic is consistent with the existing cases.
1666-1666: LGTM!The addition of the
lineafield to theDateResultByChainstruct is consistent with the existing fields.
4794-4833: LGTM!The resolver function
_DateResultByChain_lineaand its field context management are consistent with the existing resolver functions and field context management.
7191-7192: LGTM!The addition of the
lineacase in the field context management switch-case is consistent with the existing cases.
10435-10436: LGTM!The addition of the
lineacase in the resolver switch-case is consistent with the existing cases.
Comments failed to post (3)
packages/synapse-constants/scripts/utils/fetchRfqData.js
4-14: Handle network issues more gracefully.
Consider retrying the fetch request a few times before failing.
const fetchRfqData = async (retries = 3) => { try { const controller = new AbortController(); const timeoutId = setTimeout(() => controller.abort(), 5000); // 5 seconds timeout const response = await fetch(RFQ_URL, { signal: controller.signal }); clearTimeout(timeoutId); if (!response.ok) { throw new Error(`HTTP error! status: ${response.status}`); } return await response.json(); } catch (error) { if (retries > 0) { console.warn(`Retrying... (${3 - retries + 1})`); return fetchRfqData(retries - 1); } else { console.error('Failed to fetch RFQ data:', error); return []; } } };
Consider adding a timeout to the fetch request.
Adding a timeout can help prevent the function from hanging indefinitely if the server does not respond.
+ const controller = new AbortController(); + const timeoutId = setTimeout(() => controller.abort(), 5000); // 5 seconds timeout const response = await fetch(RFQ_URL, { signal: controller.signal }); + clearTimeout(timeoutId);Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.const fetchRfqData = async () => { const controller = new AbortController(); const timeoutId = setTimeout(() => controller.abort(), 5000); // 5 seconds timeout try { const response = await fetch(RFQ_URL, { signal: controller.signal }); clearTimeout(timeoutId); if (!response.ok) { throw new Error(`HTTP error! status: ${response.status}`); } return await response.json(); } catch (error) { console.error('Failed to fetch RFQ data:', error); return []; } }packages/synapse-constants/scripts/utils/prettyPrintTs.js
10-10: Add error handling for the Prettier execution step.
Consider wrapping the Prettier execution step in a try-catch block to handle potential errors.
- execSync(`npx prettier --write ${fn}`); + try { + execSync(`npx prettier --write ${fn}`); + } catch (error) { + console.error(`Failed to format file ${fn} with Prettier:`, error); + }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.try { execSync(`npx prettier --write ${fn}`); } catch (error) { console.error(`Failed to format file ${fn} with Prettier:`, error); }
5-10: Add error handling for the file writing step.
Consider wrapping the file writing step in a try-catch block to handle potential errors.
const json = JSON.stringify(map); - fs.writeFileSync(fn, `export const ${mapName} = ${json}`); + try { + fs.writeFileSync(fn, `export const ${mapName} = ${json}`); + } catch (error) { + console.error(`Failed to write file ${fn}:`, error); + return; + }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.const prettyPrintTS = (map, mapName, fn) => { console.log(`Writing ${mapName} to ${fn}`) const json = JSON.stringify(map) try { fs.writeFileSync(fn, `export const ${mapName} = ${json}`) } catch (error) { console.error(`Failed to write file ${fn}:`, error) return; } // Run prettier on the file using terminal command: execSync(`npx prettier --write ${fn}`)
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Updated Linea SVG and integrated it into the explorer UI, ensuring visibility and data representation.
- ChainChart Update: Added
Barelement forlineainpackages/explorer-ui/components/ChainChart/index.tsxwith specific fill colors. - GraphQL Query Update: Included
lineachain inDAILY_STATISTICS_BY_CHAINquery inpackages/explorer-ui/graphql/queries/index.ts. - SVG Export: Added
linea.svgexport inpackages/synapse-constants/constants/assets/chains/index.ts. - Bridge Map Update: Added new origins and destinations for tokens in
packages/synapse-constants/constants/bridgeMap.ts. - Chain Constants Update: Added Linea and Blast chains in
packages/synapse-constants/constants/chains/index.ts.
28 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2928 +/- ##
===================================================
+ Coverage 25.69758% 25.70023% +0.00265%
===================================================
Files 771 770 -1
Lines 55585 55482 -103
Branches 80 80
===================================================
- Hits 14284 14259 -25
+ Misses 39821 39748 -73
+ Partials 1480 1475 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
PR Summary
(updates since last review)
Updated Linea SVG and integrated it into the explorer UI, ensuring visibility and data representation.
- Refactored
getTxAgeFunction: Improved modularity and error handling incontrib/opbot/botmd/commands.go. - New Test for
GetTxAge: AddedTestTxAgeincontrib/opbot/botmd/commands_test.goto validate transaction age calculation. - Metrics for Address Screening: Introduced new metrics in
contrib/screener-api/screener/screener.gofor better monitoring. - OpenTelemetry Integration: Enhanced
Guardservice withotelRecorderinservices/rfq/guard/service/guard.goandotel.go. - Retry Mechanism for Withdrawals: Added retry logic in
services/rfq/relayer/cmd/commands.gofor fetching transaction hashes.
31 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Updates the linea svg so that it is visible in the explorer UI.
Summary by CodeRabbit
New Features
<Bar>component in the ChainChart for enhanced visual representation.lineafield, providing more comprehensive data.LINEAblockchain, including new tokens and constants for improved interoperability.Bug Fixes
Chores
lineaandscroll.