[DO NOT MERGE] test/sdk-rfq #2914

bigboydiamonds · 2024-07-24T16:28:01Z

null
8954400: synapse-interface preview link
5f4daa3: synapse-interface preview link

…last-rfq

coderabbitai · 2024-07-24T16:28:08Z

Important

Review skipped

Ignore keyword(s) in the title.

Ignored keywords (2)

WIP
DO NOT MERGE

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cloudflare-workers-and-pages · 2024-07-24T16:32:51Z

Deploying sanguine-fe with Cloudflare Pages

Latest commit:	`c40b618`
Status:	✅ Deploy successful!
Preview URL:	https://1108a8d8.sanguine-fe.pages.dev
Branch Preview URL:	https://test-sdk-rfq.sanguine-fe.pages.dev

View logs

greptile-apps

PR Summary

This pull request introduces several updates to support new blockchain networks and tokens, along with some debugging enhancements.

Debugging: Added console.log in packages/sdk-router/src/operations/bridge.ts for route inspection during allBridgeQuotes execution.
UI Update: Modified packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx to update the AnnouncementBanner with new RFQ transaction information.
Token Support: Updated packages/synapse-interface/constants/bridgeMap.ts to include RFQ.USDC and RFQ.ETH tokens.
Blockchain Support: Added Linea chain ID (59144) in packages/synapse-interface/constants/chains/index.tsx and integrated Linea network in packages/synapse-interface/constants/chains/master.tsx.
Dependency Management: Changed packages/synapse-interface/package.json to use a local version of @synapsecns/sdk-router for development purposes.

_{10 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps · 2024-07-24T16:28:36Z

packages/sdk-router/src/operations/bridge.ts

@@ -141,6 +141,8 @@ export async function allBridgeQuotes(
        tokenOut,
        amountIn
      )
+      console.log('routes: ', routes)


Style: Remove or replace this console.log statement with proper logging before merging to master.

greptile-apps

PR Summary

(updates since last review)

Recent changes focus on enhancing token routing and dependency management, along with adding debugging capabilities.

Token Routing: Updated packages/synapse-interface/constants/bridgeMap.ts to include 'RFQ.USDB' and 'RFQ.USDC' for USDC and USDB tokens.
Dependency Management: Updated packages/synapse-interface/package.json to use @synapsecns/sdk-router version ^0.9.0 from a package registry.
Debugging: Added test calls and logging for synapseSDK.allBridgeQuotes in packages/synapse-interface/pages/state-managed-bridge/index.tsx.

These changes improve token route flexibility, ensure stable dependency usage, and enhance debugging capabilities.

_{3 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

codecov · 2024-07-24T19:28:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49505%. Comparing base (c5cf52a) to head (c40b618).
Report is 2 commits behind head on master.

Additional details and impacted files

@@                 Coverage Diff                  @@
##              master       #2914          +/-   ##
====================================================
+ Coverage   25.71470%   90.49505%   +64.78035%     
====================================================
  Files            770          54         -716     
  Lines          55513        1010       -54503     
  Branches          80          80                  
====================================================
- Hits           14275         914       -13361     
+ Misses         39760          93       -39667     
+ Partials        1478           3        -1475

Flag	Coverage Δ
agents	`?`
cctp-relayer	`?`
core	`?`
ethergo	`?`
explorer	`?`
git-changes-action	`?`
omnirpc	`?`
opbot	`?`
packages	`90.49505% <100.00000%> (+0.00942%)`	⬆️
rfq	`?`
screener-api	`?`
scribe	`?`
tools	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abtestingalpha and others added 12 commits July 12, 2024 11:34

Adds BSC to RFQ

147d5e5

Merge branch 'master' into fe/adds-bsc-rfq

04e7522

Update banner dates

f8771d3

Merge branch 'master' into fe/adds-bsc-rfq

f0706b6

Add Blast and Linea to RFQ

5f005f7

Merge branch 'master' into fe/adds-bsc-linea-blast-rfq

47aeabc

adds linea and blast rfq routes to fe

6129fce

changing linea logo

b0b3556

Merge remote-tracking branch 'origin/master' into fe/adds-bsc-linea-b…

a10348b

…last-rfq

Merge remote-tracking branch 'origin/master' into fe/adds-bsc-linea-b…

e7ae4fc

…last-rfq

Update Linea svg

aebf66c

test

26ecd9c

bigboydiamonds requested review from abtestingalpha, aureliusbtc, ChiTimesChi and trajan0x as code owners July 24, 2024 16:28

github-actions bot added javascript Pull requests that update Javascript code M-synapse-interface Sol Typescript M-deps size/s labels Jul 24, 2024

greptile-apps bot reviewed Jul 24, 2024

View reviewed changes

Manual update bridgemap

c40b618

greptile-apps bot reviewed Jul 24, 2024

View reviewed changes

github-actions bot added the needs-yarn-install label Jul 24, 2024

bigboydiamonds closed this Jul 24, 2024

github-actions bot deleted the test/sdk-rfq branch July 24, 2024 21:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] test/sdk-rfq #2914

[DO NOT MERGE] test/sdk-rfq #2914

bigboydiamonds commented Jul 24, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Jul 24, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

cloudflare-workers-and-pages bot commented Jul 24, 2024 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Jul 24, 2024

greptile-apps bot left a comment

codecov bot commented Jul 24, 2024 •

edited

Loading

[DO NOT MERGE] test/sdk-rfq #2914

[DO NOT MERGE] test/sdk-rfq #2914

Conversation

bigboydiamonds commented Jul 24, 2024 • edited by github-actions bot Loading

coderabbitai bot commented Jul 24, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

cloudflare-workers-and-pages bot commented Jul 24, 2024 • edited Loading

Deploying sanguine-fe with Cloudflare Pages

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Jul 24, 2024

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

codecov bot commented Jul 24, 2024 • edited Loading

Codecov Report

bigboydiamonds commented Jul 24, 2024 •

edited by github-actions bot

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

cloudflare-workers-and-pages bot commented Jul 24, 2024 •

edited

Loading

codecov bot commented Jul 24, 2024 •

edited

Loading