feat(synapse-interface): adds BSC, Blast, Linea to RFQ #2905
Conversation
bigboydiamonds
requested review from
abtestingalpha and
aureliusbtc
as code owners
WalkthroughThe recent updates enhance the Synapse interface by promoting RFQ transactions specifically on the Linea blockchain. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
javascript
Deploying sanguine with
|
| Latest commit: |
72b33a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e7db96a3.sanguine.pages.dev |
| Branch Preview URL: | https://fe-adds-bsc-linea-blast-rfq.sanguine.pages.dev |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request adds support for RFQ transactions on BSC, Blast, and Linea networks.
- Updated Banner Message: Modified
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsxto display a new banner message about RFQ transactions on BSC, Blast, and Linea. - Allowed Chain IDs: Updated
packages/synapse-interface/scripts/generateMaps.jsto include chain IDs 56, 59144, and 81457 for RFQ operations.
These changes ensure users are informed about new RFQ capabilities and expand the supported blockchain networks for RFQ operations.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Deploying sanguine-fe with
|
| Latest commit: |
72b33a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c07cc322.sanguine-fe.pages.dev |
| Branch Preview URL: | https://fe-adds-bsc-linea-blast-rfq.sanguine-fe.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx (1 hunks)
- packages/synapse-interface/scripts/generateMaps.js (1 hunks)
Additional comments not posted (3)
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx (2)
54-57: Ensure the banner ID is unique.Verify that the
bannerIdis unique across the codebase to avoid conflicts.Verification successful
The banner ID is unique.
The
bannerId"2024-07-22-rfq" appears only once in the codebase, ensuring its uniqueness.
- Location:
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsxScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the uniqueness of the banner ID. # Test: Search for the banner ID in the codebase. Expect: Only one occurrence. rg --type js $'2024-07-22-rfq'Length of output: 29
Script:
#!/bin/bash # Description: Verify the uniqueness of the banner ID across all file types. # Test: Search for the banner ID in the codebase. Expect: Only one occurrence. rg '2024-07-22-rfq'Length of output: 130
54-57: Verify the correctness of the new dates and content.Ensure that the new
startDateandendDateare correct and fall within the expected range. Also, verify that thebannerContentaccurately reflects the intended message.Verification successful
Verify the correctness of the new dates and content.
The
startDateandendDateprovided in theLandingPageWrappercomponent are:
startDate: 2024-07-10T18:45:09+00:00endDate: 2024-08-15T18:45:09+00:00These dates appear to be within a reasonable range for an announcement banner. The
bannerContent"RFQ transactions now available on BSC, Blast, and Linea" accurately reflects the intended message.Ensure the banner ID is unique.
The
bannerId"2024-07-22-rfq" appears to be unique based on the context provided.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the new dates and content for the AnnouncementBanner. # Test: Check if the dates are within the expected range and the content is accurate. rg --type js -A 5 $'AnnouncementBanner'Length of output: 38
Script:
#!/bin/bash # Description: Locate the `AnnouncementBanner` component definition and its usage in the codebase. # Search for the `AnnouncementBanner` component definition rg --type tsx --type ts --type js --type jsx 'AnnouncementBanner' -A 10Length of output: 99
Script:
#!/bin/bash # Description: Locate the `AnnouncementBanner` component definition and its usage in the codebase. # Search for the `AnnouncementBanner` component definition rg --type ts --type js --type jsx 'AnnouncementBanner' -A 10Length of output: 88
Script:
#!/bin/bash # Description: Locate the `AnnouncementBanner` component definition and its usage in the codebase. # Search for the `AnnouncementBanner` component definition rg --type ts --type js 'AnnouncementBanner' -A 10Length of output: 8277
Script:
#!/bin/bash # Description: Verify the implementation of the `AnnouncementBanner` component and check the relevant lines for date and content validation. # Search for the `AnnouncementBanner` component implementation rg --type ts 'export const AnnouncementBanner' -A 10Length of output: 1162
packages/synapse-interface/scripts/generateMaps.js (1)
43-43: Verify the correctness and validity of the new chain IDs.Ensure that the new chain IDs (
56,59144,81457) are correct and valid within the context of the application.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2905 +/- ##
====================================================
+ Coverage 25.71336% 90.48563% +64.77226%
====================================================
Files 770 54 -716
Lines 55512 1009 -54503
Branches 80 80
====================================================
- Hits 14274 913 -13361
+ Misses 39760 93 -39667
+ Partials 1478 3 -1475
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
PR Summary
(updates since last review)
This pull request adds support for RFQ transactions on BSC, Blast, and Linea networks, along with various dependency updates and enhancements.
- Updated Go Version and Dependencies: Updated
go.modfiles across multiple modules to Go 1.22.1 and addedgithub.aaakk.us.kg/samborkent/uuidfor UUID generation. - Enhanced RFQ Functionality: Added new environment variables and deployment configurations for BSC, Blast, and Linea in
packages/contracts-rfq. - Improved Error Handling: Modified
core/retry/retry.goto usego.uber.org/multierrfor better error aggregation. - New Testnet Scripts: Added
testnet-fb-config.shandtestnet-fb-deploy.shscripts for configuring and deploying FastBridge contracts on testnets. - Updated Metrics Handling: Enhanced
core/metrics/base.goandcore/metrics/otlp.gofor better tracer provider management and graceful shutdown.
85 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
This pull request adds support for RFQ transactions on BSC, Blast, and Linea networks, enhancing the Synapse interface's compatibility and functionality.
packages/synapse-interface/constants/bridgeMap.ts: Added support for BSC, Blast, and Linea by defining new chain IDs and mapping token addresses.packages/synapse-interface/constants/chains/index.tsx: Introduced new chain IDs for Blast and Linea, expanding chain data mappings.packages/synapse-interface/constants/chains/master.tsx: Included Linea blockchain network with detailed properties and configurations.packages/synapse-interface/constants/chains/supportedChains.ts: Added BSC, Blast, and Linea to thesupportedChainsarray.packages/synapse-interface/constants/tokens/bridgeable.ts: Included token addresses and decimals for Linea and Scroll networks for USDC, USDT, and ETH tokens.
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
packages/synapse-interface/assets/chains/linea.svgis excluded by!**/*.svg
Files selected for processing (6)
- packages/synapse-interface/constants/bridgeMap.ts (4 hunks)
- packages/synapse-interface/constants/chains/index.tsx (1 hunks)
- packages/synapse-interface/constants/chains/master.tsx (2 hunks)
- packages/synapse-interface/constants/chains/supportedChains.ts (2 hunks)
- packages/synapse-interface/constants/tokens/bridgeable.ts (5 hunks)
- packages/synapse-interface/scripts/data/providers.json (1 hunks)
Additional comments not posted (12)
packages/synapse-interface/constants/chains/supportedChains.ts (2)
21-21: LGTM! Import statement correctly updated.The
lineachain is correctly added to the import statement.
34-34: LGTM!supportedChainsarray correctly updated.The
lineachain is correctly added to thesupportedChainsarray.packages/synapse-interface/scripts/data/providers.json (1)
19-19: LGTM! JSON configuration correctly updated.The
lineaRPC endpoint is correctly added to the JSON configuration.packages/synapse-interface/constants/chains/index.tsx (1)
55-55: LGTM!ChainIdobject correctly updated.The
LINEAchain ID is correctly added to theChainIdobject.packages/synapse-interface/constants/chains/master.tsx (1)
568-592: LGTM! TheLINEAblockchain entity addition is consistent and comprehensive.The properties defined for
LINEAare consistent with the format used for other blockchain entities in the file.packages/synapse-interface/constants/tokens/bridgeable.ts (3)
414-414: LGTM! TheLINEAentry inUSDCtoken definition is consistent.The address and decimal value for
CHAINS.LINEA.idare consistent with the format used for other chains in theUSDCtoken definition.Also applies to: 431-431
471-471: LGTM! TheSCROLLentry inUSDTtoken definition is consistent.The address and decimal value for
CHAINS.SCROLL.idare consistent with the format used for other chains in theUSDTtoken definition.Also applies to: 484-484
710-710: LGTM! TheLINEAentry inETHtoken definition is consistent.The entry for
CHAINS.LINEA.idwith a value ofzeroAddressis consistent with the format used for other chains in theETHtoken definition.packages/synapse-interface/constants/bridgeMap.ts (4)
1796-1810: Verify the correctness of the added entries for chain ID '59144'.The entries for USDC and ETH tokens appear to be correctly structured with appropriate properties. Ensure that these tokens are correctly integrated and tested within the broader system.
Line range hint
1823-1857:
Verify the consistency of the modified entries for chain ID '81457'.The modifications to the USDB and WETH tokens include references to the new RFQ tokens. Ensure that these changes are consistent with the new RFQ functionality and are properly tested.
Line range hint
1858-1869:
Verify the correctness of the added entries for chain ID '534352'.The entries for USDC and ETH tokens appear to be correctly structured with appropriate properties. Ensure that these tokens are correctly integrated and tested within the broader system.
Line range hint
1870-1888:
Verify the consistency of the modified entries for chain ID '1313161554'.The modifications to the nUSD, USDT.e, and USDC.e tokens include references to the new RFQ tokens. Ensure that these changes are consistent with the new RFQ functionality and are properly tested.
There was a problem hiding this comment.
PR Summary
(updates since last review)
Added support for RFQ transactions on BSC, Blast, and Linea networks, enhancing the Synapse interface's compatibility and functionality.
packages/synapse-interface/constants/bridgeMap.ts: Defined new chain IDs and mapped token addresses for BSC, Blast, and Linea.packages/synapse-interface/constants/chains/index.tsx: Introduced new chain IDs for Blast and Linea, expanding chain data mappings.packages/synapse-interface/constants/chains/master.tsx: Included Linea blockchain network with detailed properties and configurations.packages/synapse-interface/constants/chains/supportedChains.ts: Added BSC, Blast, and Linea to thesupportedChainsarray.packages/synapse-interface/constants/tokens/bridgeable.ts: Included token addresses and decimals for Linea and Scroll networks for USDC, USDT, and ETH tokens.
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
Added support for RFQ transactions on BSC, Blast, and Linea networks, enhancing the Synapse interface's compatibility and functionality.
contrib/opbot/botmd/commands.go: RefactoredgetTxAgefunction for improved readability and error handling.packages/sdk-router/src/constants/chainIds.ts: Added new chain IDs for LINEA and BLAST networks.packages/sdk-router/src/constants/medianTime.ts: Updated median transaction times for BSC, Blast, and Linea.packages/synapse-interface/components/StateManagedBridge/SettingsToggle.tsx: Introduced a newSettingsTogglecomponent.packages/synapse-interface/pages/state-managed-bridge/index.tsx: Refactored settings toggle functionality and updated bridge transaction logic for new chain IDs.
10 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
Added support for RFQ transactions on BSC, Blast, and Linea networks, enhancing the Synapse interface's compatibility and functionality.
packages/rest-api/package.json: Updated@synapsecns/sdk-routerdependency to 0.9.0.packages/sdk-router/CHANGELOG.md: Documented new features for Blast and Linea support in version 0.9.0.packages/sdk-router/package.json: Bumped version to 0.9.0 and specified Node.js engine requirement as >=18.17.0.packages/synapse-interface/package.json: Updated@synapsecns/sdk-routerdependency to 0.9.0.packages/widget/package.json: Updated@synapsecns/sdk-routerdependency to 0.9.0.
8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
Added support for RFQ transactions on BSC, Blast, and Linea networks, enhancing the Synapse interface's compatibility and functionality.
packages/synapse-interface/src/components/AnnouncementBanner.tsx: Updated to promote RFQ transactions on BSC, Blast, and Linea with new display dates.packages/sdk-router/src/constants.ts: Expanded allowed chain IDs for RFQ transactions.packages/sdk-router/src/rpcEndpoints.ts: Introduced a new RPC endpoint for the Linea network.packages/sdk-router/src/tokens.ts: Enhanced token definitions to support USDC, USDT, and ETH on the LINEA chain.packages/sdk-router/src/index.ts: Added support for the LINEA blockchain.
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
The latest changes add support for RFQ transactions on BSC, Blast, and Linea networks, enhancing the Synapse interface's compatibility and functionality.
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx: Updated announcement banner to promote Linea blockchain support and updated display dates.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
packages/synapse-interface/assets/chains/linea.svgis excluded by!**/*.svg
Files selected for processing (1)
- packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx
Summary by CodeRabbit
0425b78: synapse-interface preview link
f51f5e2: synapse-interface preview link
b5ce561: synapse-interface preview link
9c650fe: synapse-interface preview link
6a745c1: synapse-interface preview link
7d047b2: synapse-interface preview link
14170d3: synapse-interface preview link
bedf841: synapse-interface preview link