-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
li.fi advisory #2877
li.fi advisory #2877
Conversation
- @synapsecns/[email protected]
* Init lifi approval revoke page * get rid of victim address and use connected address * Add some text * Only show approval data once connected * Multi-chain checker * Correct token adddresses per chain usdc/usdt/weth * Style update --------- Co-authored-by: aureliusbtc <[email protected]>
Caution Review failedThe pull request is closed. WalkthroughThe recent updates span multiple packages, with the primary changes being version bumps and minor configuration updates. Specifically, the Changes
Sequence Diagram(s)Changes are too varied to generate a meaningful sequence diagram. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Added
packages/contracts-rfq/deployments/bnb/.chainId
to specify BSC chain ID (56) - Added
packages/contracts-rfq/deployments/bnb/FastBridge.json
with BSC deployment details - Updated
packages/contracts-rfq/foundry.toml
to include BNB RPC and Etherscan configurations - Enhanced
packages/synapse-interface/pages/lifi/index.tsx
to support BSC, update token addresses, and improve token allowance management - Version bumps in
packages/contracts-rfq/package.json
andpackages/synapse-interface/package.json
7 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
{ | ||
"address": "0x5523D3c98809DdDB82C686E152F5C58B1B0fB59E", | ||
"constructorArgs": "0x000000000000000000000000bd88862fcc17de436f7bd17276c537acadda9a67" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style: Add a newline at the end of the file for better formatting.
} | |
} | |
Bundle ReportChanges will decrease total bundle size by 698.28kB ⬇️
|
Description
add lifi page
Summary by CodeRabbit
New Features
FastBridge
smart contract.Bug Fixes
LifiPage
component.LifiPage
component.Chores
Refactor
LifiPage
component.ec43e6f: synapse-interface preview link