Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

li.fi advisory #2877

Merged
merged 4 commits into from
Jul 16, 2024
Merged

li.fi advisory #2877

merged 4 commits into from
Jul 16, 2024

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Jul 16, 2024

Description

add lifi page

Summary by CodeRabbit

  • New Features

    • Introduced a JSON configuration file specifying deployment information for the FastBridge smart contract.
  • Bug Fixes

    • Improved token allowance display and interaction in the LifiPage component.
    • Enhanced UI elements and layout in the LifiPage component.
  • Chores

    • Updated project metadata and configuration files to reflect version increments and network settings.
  • Refactor

    • Reorganized imports and updated logic for fetching token allowances based on chain ID and token address in the LifiPage component.

ec43e6f: synapse-interface preview link

trajan0x and others added 4 commits July 16, 2024 13:37
* Init lifi approval revoke page

* get rid of victim address and use connected address

* Add some text

* Only show approval data once connected

* Multi-chain checker

* Correct token adddresses  per chain usdc/usdt/weth

* Style update

---------

Co-authored-by: aureliusbtc <[email protected]>
@trajan0x trajan0x merged commit a24ab81 into fe-release Jul 16, 2024
30 of 31 checks passed
Copy link
Contributor

coderabbitai bot commented Jul 16, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent updates span multiple packages, with the primary changes being version bumps and minor configuration updates. Specifically, the contracts-rfq package has seen updates to deployment configuration files and a version increment. Similarly, the synapse-interface package has experienced a minor version bump along with enhancements to the lifi page, including token management logic and UI improvements.

Changes

Files/Paths Change Summary
packages/contracts-rfq/CHANGELOG.md Updated version number from 0.2.10 to 0.2.11 for FastBridge.
packages/contracts-rfq/deployments/bnb/.chainId Added chain ID 56.
packages/contracts-rfq/deployments/bnb/FastBridge.json Introduced JSON file specifying Ethereum address and constructor arguments for a contract deployment.
packages/contracts-rfq/foundry.toml Added configuration for BNB RPC and verifier for BNB network.
packages/contracts-rfq/package.json Updated project version from 0.2.10 to 0.2.11.
packages/synapse-interface/CHANGELOG.md Updated version number from 0.28.1 to 0.28.2.
packages/synapse-interface/package.json Updated project version from 0.28.1 to 0.28.2 and maintained Node.js version requirements.
packages/synapse-interface/pages/lifi/index.tsx Enhanced token management logic, updated imports, modified UI elements and interaction, added constants and state variables.

Sequence Diagram(s)

Changes are too varied to generate a meaningful sequence diagram.

Poem

In the realm of code so fine,
Version bumps and updates align.
Tokens added, UI's renewed,
Synapse connected, changes ensued.
With each commit, progress we see,
A developer's dream, code running free.
Let's celebrate this digital spree! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Added packages/contracts-rfq/deployments/bnb/.chainId to specify BSC chain ID (56)
  • Added packages/contracts-rfq/deployments/bnb/FastBridge.json with BSC deployment details
  • Updated packages/contracts-rfq/foundry.toml to include BNB RPC and Etherscan configurations
  • Enhanced packages/synapse-interface/pages/lifi/index.tsx to support BSC, update token addresses, and improve token allowance management
  • Version bumps in packages/contracts-rfq/package.json and packages/synapse-interface/package.json

7 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

{
"address": "0x5523D3c98809DdDB82C686E152F5C58B1B0fB59E",
"constructorArgs": "0x000000000000000000000000bd88862fcc17de436f7bd17276c537acadda9a67"
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Add a newline at the end of the file for better formatting.

Suggested change
}
}

Copy link

codecov bot commented Jul 16, 2024

Bundle Report

Changes will decrease total bundle size by 698.28kB ⬇️

Bundle name Size Change
sdk-router-@synapsecns/sdk-router-cjs 116.93kB 404.83kB ⬇️
sdk-router-@synapsecns/sdk-router-esm 252.15kB 0 bytes
synapse-interface-server-cjs 1.38MB 8.63kB ⬇️
synapse-interface-client-array-push 7.45MB 11.53kB ⬇️
synapse-interface-edge-server-array-push 83 bytes 0 bytes
widget-esm-cjs 275.25kB 0 bytes
widget-cjs-esm (removed) 273.3kB ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants