-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy #2875
deploy #2875
Conversation
* Adds BSC to RFQ * swaps out bsc for arb in test
- @synapsecns/[email protected] - @synapsecns/[email protected] - @synapsecns/[email protected] - @synapsecns/[email protected]
* Init lifi approval revoke page * get rid of victim address and use connected address * Add some text * Only show approval data once connected * Multi-chain checker
Warning Rate limit exceeded@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 21 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe updates primarily involve version increments and the addition of BSC support to the SDK. Version changes affect several packages ( Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant LifiPage
participant SynapseSDK
participant Blockchain
User->>+LifiPage: Open LifiPage
LifiPage->>+SynapseSDK: Get token allowances
SynapseSDK->>+Blockchain: Fetch allowances for tokens
Blockchain-->>-SynapseSDK: Return allowances
SynapseSDK-->>-LifiPage: Provide token allowance details
LifiPage-->>User: Display token allowances
User->>+LifiPage: Revoke token approval
LifiPage->>+SynapseSDK: Revoke token approval
SynapseSDK->>+Blockchain: Submit revoke transaction
Blockchain-->>-SynapseSDK: Confirmation of revocation
SynapseSDK-->>-LifiPage: Inform about revocation success
LifiPage-->>User: Display revocation success
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Updated
packages/rest-api/package.json
to bump version to 1.0.67 and update@synapsecns/sdk-router
dependency to ^0.8.0. - Added BSC to RFQ in
packages/sdk-router/src/constants/chainIds.ts
. - Updated
packages/sdk-router/src/constants/medianTime.ts
to include BSC with a median time of 15 seconds. - Modified
packages/sdk-router/src/sdk.test.ts
to replace BSC with ARBITRUM in tests. - Introduced
packages/synapse-interface/pages/lifi/index.tsx
for revoking token approvals for the Li.fi protocol.
11 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
@@ -0,0 +1,147 @@ | |||
import Grid from '@tw/Grid' | |||
import { useEffect, useState } from 'react' | |||
import { useAccount, useAccountEffect, useSwitchChain } from 'wagmi' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style: The useAccountEffect
import is unused and can be removed.
> | ||
<div className="pb-3 place-self-center"> | ||
<div> | ||
<h3>Li.fi / Jumper is investigating an ongoing exploit, and users should revoke approvals <a className="underline" target="_blank" href="https://x.com/lifiprotocol/status/1813196697641570635">- Li.fi Tweet</a></h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: The URL in the anchor tag should be updated to a valid link. The current link to 'x.com' is likely incorrect.
Description
deploy to fe-release
Summary by CodeRabbit
New Features
LifiPage
component to manage Li.fi approvals across multiple chains, allowing users to view and revoke ERC20 token approvals.Dependency Updates
@synapsecns/sdk-router
to version0.8.0
across several packages.@synapsecns/rest-api
,@synapsecns/synapse-interface
, and@synapsecns/widget
to match dependency updates.Enhancements
466ba94: synapse-interface preview link