feat(widget): add unsupported network #2860

bigboydiamonds · 2024-07-09T01:12:24Z

Summary by CodeRabbit

New Features
- Added detailed native currency information for multiple blockchain networks, including Ethereum, Binance Coin, Avax, and more.
Enhancements
- Updated the 'Switch Network' functionality to include new parameters for smoother network switching.

These changes improve clarity and usability for end-users interacting with various blockchain networks within the app.

coderabbitai · 2024-07-09T01:12:34Z

Walkthrough

The changes introduce a nativeCurrency field to the chain objects in chains.ts, specifying the name, symbol, and decimals for the native currencies of various blockchain networks. The Chain interface in index.d.ts is updated to include this new field. Additionally, switchNetwork.ts imports CHAINS_BY_ID to utilize the new nativeCurrency details when switching networks.

Changes

Files/Paths	Change Summary
`packages/widget/src/constants/chains.ts`	Added `nativeCurrency` details (name, symbol, decimals) to multiple chain objects.
`packages/widget/src/types/index.d.ts`	Added `nativeCurrency` field (name, symbol, decimals) to the `Chain` interface.
`packages/widget/src/utils/actions/switchNetwork.ts`	Imported `CHAINS_BY_ID` and utilized new `nativeCurrency` info in `switchNetwork` function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Widget
    participant Provider

    User ->> Widget: Switch Network
    Widget ->> CHAINS_BY_ID: Get chain by ID
    CHAINS_BY_ID ->> Widget: Return Chain Object
    Widget ->> Provider: wallet_addEthereumChain with nativeCurrency
    Provider ->> Widget: Confirm Network Switch
    Widget ->> User: Network Switched

Poem

In a land where currencies gleam,
Chains now hold a native dream.
ETH, BNB, and MATIC too,
Switch networks with ease, anew.
With details fine, and symbols bright,
The widget dances in the light.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

greptile-apps

PR Summary

Added nativeCurrency field to each chain object in packages/widget/src/constants/chains.ts
Updated Chain interface in packages/widget/src/types/index.d.ts to include native currency properties
Enhanced switchNetwork function in packages/widget/src/utils/actions/switchNetwork.ts to add unrecognized networks using wallet_addEthereumChain method

_{3 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9779cda and cdd16ac.

Files selected for processing (3)

packages/widget/src/constants/chains.ts (21 hunks)
packages/widget/src/types/index.d.ts (1 hunks)
packages/widget/src/utils/actions/switchNetwork.ts (2 hunks)

Additional comments not posted (24)

packages/widget/src/utils/actions/switchNetwork.ts (2)

2-2: Ensure CHAINS_BY_ID contains all necessary chain data.

The new import for CHAINS_BY_ID is used to retrieve chain details. Verify that CHAINS_BY_ID includes all required chain information.

13-22: LGTM! But verify error handling for provider.send.

The code changes are approved.

Ensure that the provider.send calls handle errors appropriately, especially for wallet_addEthereumChain and wallet_switchEthereumChain.

packages/widget/src/types/index.d.ts (1)

87-91: LGTM! But verify the implementation of nativeCurrency across all chain objects.

The code changes are approved.

Ensure that all chain objects correctly implement the new nativeCurrency property.

packages/widget/src/constants/chains.ts (21)

16-20: LGTM!

The addition of the nativeCurrency property to the ETHEREUM chain object is correct.

35-39: LGTM!

The addition of the nativeCurrency property to the ARBITRUM chain object is correct.

54-58: LGTM!

The addition of the nativeCurrency property to the BNBCHAIN chain object is correct.

73-77: LGTM!

The addition of the nativeCurrency property to the AVALANCHE chain object is correct.

92-96: LGTM!

The addition of the nativeCurrency property to the CANTO chain object is correct.

111-115: LGTM!

The addition of the nativeCurrency property to the OPTIMISM chain object is correct.

130-134: LGTM!

The addition of the nativeCurrency property to the POLYGON chain object is correct.

149-153: LGTM!

The addition of the nativeCurrency property to the DFK chain object is correct.

168-172: LGTM!

The addition of the nativeCurrency property to the KLAYTN chain object is correct.

187-191: LGTM!

The addition of the nativeCurrency property to the FANTOM chain object is correct.

206-210: LGTM!

The addition of the nativeCurrency property to the CRONOS chain object is correct.

225-229: LGTM!

The addition of the nativeCurrency property to the BOBA chain object is correct.

244-248: LGTM!

The addition of the nativeCurrency property to the METIS chain object is correct.

263-267: LGTM!

The addition of the nativeCurrency property to the AURORA chain object is correct.

282-286: LGTM!

The addition of the nativeCurrency property to the HARMONY chain object is correct.

301-305: LGTM!

The addition of the nativeCurrency property to the MOONBEAM chain object is correct.

320-324: LGTM!

The addition of the nativeCurrency property to the MOONRIVER chain object is correct.

339-343: LGTM!

The addition of the nativeCurrency property to the DOGE chain object is correct.

358-362: LGTM!

The addition of the nativeCurrency property to the BASE chain object is correct.

378-382: LGTM!

The addition of the nativeCurrency property to the BLAST chain object is correct.

397-401: LGTM!

The addition of the nativeCurrency property to the SCROLL chain object is correct.

cloudflare-workers-and-pages · 2024-07-09T01:17:39Z

Deploying sanguine-fe with Cloudflare Pages

Latest commit:	`84eaf76`
Status:	✅ Deploy successful!
Preview URL:	https://eaa4eda7.sanguine-fe.pages.dev
Branch Preview URL:	https://widget-add-unrecognized-netw.sanguine-fe.pages.dev

View logs

codecov · 2024-07-09T01:19:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.67477%. Comparing base (9779cda) to head (84eaf76).
Report is 3 commits behind head on master.

Additional details and impacted files

@@                 Coverage Diff                 @@
##              master       #2860         +/-   ##
===================================================
+ Coverage   25.35936%   25.67477%   +0.31540%     
===================================================
  Files            784         769         -15     
  Lines          56350       55315       -1035     
  Branches          80          80                 
===================================================
- Hits           14290       14202         -88     
+ Misses         40581       39637        -944     
+ Partials        1479        1476          -3

Flag	Coverage Δ
packages	`90.47619% <ø> (ø)`
promexporter	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

greptile-apps

PR Summary

(updates since last review)

Added networkName and networkUrl properties to chain objects in packages/widget/src/constants/chains.ts
Updated Chain interface in packages/widget/src/types/index.d.ts to include networkName and networkUrl
Enhanced switchNetwork function in packages/widget/src/utils/actions/switchNetwork.ts to support networkName and networkUrl parameters

_{3 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

Updated network URLs for Fantom and Scroll chains in packages/widget/src/constants/chains.ts
Ensured URLs are correctly formatted without trailing slashes

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cdd16ac and 84eaf76.

Files selected for processing (3)

packages/widget/src/constants/chains.ts (21 hunks)
packages/widget/src/types/index.d.ts (1 hunks)
packages/widget/src/utils/actions/switchNetwork.ts (2 hunks)

Files skipped from review as they are similar to previous changes (3)

packages/widget/src/constants/chains.ts
packages/widget/src/types/index.d.ts
packages/widget/src/utils/actions/switchNetwork.ts

bigboydiamonds added 2 commits July 8, 2024 18:08

Add nativeCurrency field to Chain

c36faf5

Add unsupported network to wallet when switching network

cdd16ac

bigboydiamonds requested a review from trajan0x as a code owner July 9, 2024 01:12

bigboydiamonds changed the title ~~feat(widget): add unsupported network~~ [wip] feat(widget): add unsupported network Jul 9, 2024

bigboydiamonds marked this pull request as draft July 9, 2024 01:12

github-actions bot added Sol Typescript size/s labels Jul 9, 2024

greptile-apps bot reviewed Jul 9, 2024

View reviewed changes

coderabbitai bot reviewed Jul 9, 2024

View reviewed changes

bigboydiamonds added 2 commits July 9, 2024 14:44

Add network name, url to use when adding unsupported network

f9ab0c6

Update for tests, ensure wallet prompt shows no errors

6eb09b5

bigboydiamonds marked this pull request as ready for review July 9, 2024 21:59

bigboydiamonds changed the title ~~[wip] feat(widget): add unsupported network~~ feat(widget): add unsupported network Jul 9, 2024

bigboydiamonds requested a review from abtestingalpha July 9, 2024 21:59

greptile-apps bot reviewed Jul 9, 2024

View reviewed changes

abtestingalpha approved these changes Jul 10, 2024

View reviewed changes

Standardize network urls

84eaf76

greptile-apps bot reviewed Jul 10, 2024

View reviewed changes

coderabbitai bot reviewed Jul 10, 2024

View reviewed changes

bigboydiamonds merged commit 5ba1cb5 into master Jul 10, 2024
36 checks passed

bigboydiamonds deleted the widget/add-unrecognized-network branch July 10, 2024 19:55

coderabbitai bot mentioned this pull request Feb 18, 2025

New Chains #3521

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(widget): add unsupported network #2860

feat(widget): add unsupported network #2860

bigboydiamonds commented Jul 9, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 9, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

greptile-apps bot left a comment

coderabbitai bot left a comment

cloudflare-workers-and-pages bot commented Jul 9, 2024 •

edited

Loading

codecov bot commented Jul 9, 2024 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot left a comment

coderabbitai bot left a comment

feat(widget): add unsupported network #2860

feat(widget): add unsupported network #2860

Conversation

bigboydiamonds commented Jul 9, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jul 9, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

coderabbitai bot left a comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Jul 9, 2024 • edited Loading

Deploying sanguine-fe with Cloudflare Pages

codecov bot commented Jul 9, 2024 • edited Loading

Codecov Report

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

coderabbitai bot left a comment

Choose a reason for hiding this comment

bigboydiamonds commented Jul 9, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 9, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

cloudflare-workers-and-pages bot commented Jul 9, 2024 •

edited

Loading

codecov bot commented Jul 9, 2024 •

edited

Loading