Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFQ Relayer: add request status count metric #2856
RFQ Relayer: add request status count metric #2856
Changes from 10 commits
ed32478
942d308
0b3cf98
18229d0
ce386ec
89fdc50
e23d442
5fa7fa8
fd823aa
fa56096
5103182
f19af1b
45cfeaa
275a643
b437e64
1a96b28
c52717c
616feb5
3e0dc86
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 152 in services/rfq/relayer/reldb/base/quote.go
Codecov / codecov/patch
services/rfq/relayer/reldb/base/quote.go#L148-L152
Check warning on line 164 in services/rfq/relayer/reldb/base/quote.go
Codecov / codecov/patch
services/rfq/relayer/reldb/base/quote.go#L154-L164
Check warning on line 169 in services/rfq/relayer/reldb/base/quote.go
Codecov / codecov/patch
services/rfq/relayer/reldb/base/quote.go#L166-L169
Check warning on line 171 in services/rfq/relayer/reldb/base/quote.go
Codecov / codecov/patch
services/rfq/relayer/reldb/base/quote.go#L171
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 spelling: Typo in error message: should be 'could not create status count gauge'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 spelling: Typo in error message: should be 'could not create status count gauge'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 spelling: Typo in error message: should be 'could not create status count gauge'
Check warning on line 51 in services/rfq/relayer/service/otel.go
Codecov / codecov/patch
services/rfq/relayer/service/otel.go#L40-L51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 spelling: Typo in error message: should be 'could not register callback for status count gauge'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 spelling: Typo in error message: should be 'could not register callback for status count gauge'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 spelling: Typo in error message: should be 'could not register callback for status count gauge'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 spelling: Typo in error message: should be 'could not register callback for status count gauge'
Check warning on line 56 in services/rfq/relayer/service/otel.go
Codecov / codecov/patch
services/rfq/relayer/service/otel.go#L53-L56
Check warning on line 58 in services/rfq/relayer/service/otel.go
Codecov / codecov/patch
services/rfq/relayer/service/otel.go#L58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve error messages for better debugging.
The error messages in the
newOtelRecorder
method could be more specific to aid in debugging.Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪶 style: Consider logging an error or warning if any of these conditions are true.
Check warning on line 64 in services/rfq/relayer/service/otel.go
Codecov / codecov/patch
services/rfq/relayer/service/otel.go#L61-L64
Check warning on line 74 in services/rfq/relayer/service/otel.go
Codecov / codecov/patch
services/rfq/relayer/service/otel.go#L66-L74
Check warning on line 76 in services/rfq/relayer/service/otel.go
Codecov / codecov/patch
services/rfq/relayer/service/otel.go#L76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 spelling: Typo in method name: should be 'RecordStatusCount'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📚 spelling: Typo in method name: should be 'RecordStatusCount'
Check warning on line 81 in services/rfq/relayer/service/otel.go
Codecov / codecov/patch
services/rfq/relayer/service/otel.go#L80-L81
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 149 in services/rfq/relayer/service/relayer.go
Codecov / codecov/patch
services/rfq/relayer/service/relayer.go#L146-L149
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve error messages and add tests.
The error messages could be more specific to aid in debugging. Additionally, these lines are not covered by tests.
Do you want me to generate the unit testing code or open a GitHub issue to track this task?
Committable suggestion
Tools
GitHub Check: codecov/patch
Check warning on line 168 in services/rfq/relayer/service/relayer.go
Codecov / codecov/patch
services/rfq/relayer/service/relayer.go#L168
Check warning on line 295 in services/rfq/relayer/service/relayer.go
Codecov / codecov/patch
services/rfq/relayer/service/relayer.go#L290-L295
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve error messages and add tests.
The error messages could be more specific to aid in debugging. Additionally, these lines are not covered by tests.
Do you want me to generate the unit testing code or open a GitHub issue to track this task?
Committable suggestion
Tools
GitHub Check: codecov/patch
Check warning on line 392 in services/rfq/relayer/service/relayer.go
Codecov / codecov/patch
services/rfq/relayer/service/relayer.go#L380-L392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve error messages for better debugging.
The error messages in the
recordMetrics
method could be more specific to aid in debugging.Committable suggestion