Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFQ Relayer: cap db semaphore #2852

Merged
merged 2 commits into from
Jul 7, 2024
Merged

RFQ Relayer: cap db semaphore #2852

merged 2 commits into from
Jul 7, 2024

Conversation

dwasse
Copy link
Collaborator

@dwasse dwasse commented Jul 7, 2024

Summary by CodeRabbit

  • Performance Improvements
    • Reduced the number of maximum concurrent requests from 150 to 15 to enhance system stability and performance.

Copy link
Contributor

coderabbitai bot commented Jul 7, 2024

Walkthrough

The primary change in the codebase is a reduction in the maxConcurrentRequests constant from 150 to 15 within relayer.go. This change is intended to limit the number of concurrent requests handled by the relayer service, potentially improving performance stability and managing resource utilization more effectively.

Changes

File Path Change Summary
.../services/rfq/relayer/... maxConcurrentRequests changed from 150 to 15

Poem

In code where whispers thread and weave,
Requests now fewer, down by threes,
From frantic rush of one-five-oh,
To calm and steady, fifteen's flow.
The relayer breathes, with lighter breeze,
A gentler dance in networks' seas.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added go Pull requests that update Go code size/xs labels Jul 7, 2024
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Reduced maxConcurrentRequests from 150 to 15 in services/rfq/relayer/service/relayer.go
  • Adjusted semaphore in Relayer struct to reflect new limit

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e401a73 and 96d2a91.

Files selected for processing (1)
  • services/rfq/relayer/service/relayer.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • services/rfq/relayer/service/relayer.go

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.65579%. Comparing base (e401a73) to head (96d2a91).

Additional details and impacted files
@@              Coverage Diff              @@
##              master       #2852   +/-   ##
=============================================
  Coverage   25.65579%   25.65579%           
=============================================
  Files            768         768           
  Lines          55239       55239           
  Branches          80          80           
=============================================
  Hits           14172       14172           
  Misses         39594       39594           
  Partials        1473        1473           
Flag Coverage Δ
opbot 0.18564% <ø> (ø)
rfq 24.94357% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 96d2a91
Status: ✅  Deploy successful!
Preview URL: https://5c91128c.sanguine-fe.pages.dev
Branch Preview URL: https://feat-rfq-lower-sem.sanguine-fe.pages.dev

View logs

@trajan0x trajan0x merged commit 2d8fd40 into master Jul 7, 2024
32 checks passed
@trajan0x trajan0x deleted the feat/rfq-lower-sem branch July 7, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants