-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
listener: fix listener on l2 #2774
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant ctx as Context
participant Listener as chainListener
participant Client as BlockchainClient
Note over Listener, Client: Old Flow
Listener ->>+ Client: BlockByNumber(ctx, blockNumber)
Client -->>- Listener: Return Full Block
Listener ->> Listener: blockNumber := block.Number()
Note over Listener, Client: New Flow
Listener ->>+ Client: HeaderByNumber(ctx, blockNumber)
Client -->>- Listener: Return Block Header
Listener ->> Listener: blockNumber := block.Number
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2774 +/- ##
===================================================
- Coverage 25.56591% 25.29940% -0.26652%
===================================================
Files 757 755 -2
Lines 54205 54108 -97
Branches 80 80
===================================================
- Hits 13858 13689 -169
- Misses 38925 39006 +81
+ Partials 1422 1413 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Modified
getBlockNumber
to useHeaderByNumber
instead ofBlockByNumber
- Ensured compatibility with Layer 2 solutions
- Addressed issue with unsupported transaction types
1 file(s) reviewed, no comment(s)
Deploying sanguine-fe with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
fixes listener when tx type is unsupported
Summary by CodeRabbit