Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listener: fix listener on l2 #2774

Merged
merged 1 commit into from
Jun 22, 2024
Merged

listener: fix listener on l2 #2774

merged 1 commit into from
Jun 22, 2024

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Jun 22, 2024

Description

fixes listener when tx type is unsupported

Summary by CodeRabbit

  • Refactor
    • Optimized the block number retrieval process by fetching block headers instead of full blocks, improving performance and efficiency.

Copy link
Contributor

coderabbitai bot commented Jun 22, 2024

Walkthrough

The getBlockNumber method in the chainListener struct is optimized to retrieve block headers instead of full blocks. This is achieved by replacing the BlockByNumber method with HeaderByNumber and directly assigning the block number from the header's field. This change improves efficiency by reducing the amount of data retrieved and processed.

Changes

File Change Summary
ethergo/listener/listener.go Updated getBlockNumber method to use HeaderByNumber instead of BlockByNumber for block retrieval.

Sequence Diagram(s)

sequenceDiagram
    participant ctx as Context
    participant Listener as chainListener
    participant Client as BlockchainClient
    
    Note over Listener, Client: Old Flow
    Listener ->>+ Client: BlockByNumber(ctx, blockNumber)
    Client -->>- Listener: Return Full Block
    Listener ->> Listener: blockNumber := block.Number()
    
    Note over Listener, Client: New Flow
    Listener ->>+ Client: HeaderByNumber(ctx, blockNumber)
    Client -->>- Listener: Return Block Header
    Listener ->> Listener: blockNumber := block.Number
Loading

Poem

In code we crafted with delight,
Headers gained a lighter flight,
From blocks to heads, we made the switch,
A small tweak, a perfect pitch.
Now numbers shine in swift array,
Efficiency shall lead the way! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added go Pull requests that update Go code size/xs labels Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.29940%. Comparing base (99185a5) to head (4514e87).

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #2774         +/-   ##
===================================================
- Coverage   25.56591%   25.29940%   -0.26652%     
===================================================
  Files            757         755          -2     
  Lines          54205       54108         -97     
  Branches          80          80                 
===================================================
- Hits           13858       13689        -169     
- Misses         38925       39006         +81     
+ Partials        1422        1413          -9     
Flag Coverage Δ
cctp-relayer 31.93780% <ø> (ø)
omnirpc 33.08129% <ø> (ø)
opbot 0.00000% <ø> (ø)
promexporter 9.86717% <ø> (ø)
tools 30.55118% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trajan0x trajan0x marked this pull request as ready for review June 22, 2024 21:15
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Modified getBlockNumber to use HeaderByNumber instead of BlockByNumber
  • Ensured compatibility with Layer 2 solutions
  • Addressed issue with unsupported transaction types

1 file(s) reviewed, no comment(s)

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4514e87
Status: ✅  Deploy successful!
Preview URL: https://e3bd8508.sanguine-fe.pages.dev
Branch Preview URL: https://fix-l2-listener.sanguine-fe.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 99185a5 and 4514e87.

Files selected for processing (1)
  • ethergo/listener/listener.go (1 hunks)

ethergo/listener/listener.go Show resolved Hide resolved
@trajan0x trajan0x merged commit 719dcf3 into master Jun 22, 2024
55 of 56 checks passed
@trajan0x trajan0x deleted the fix/l2-listener branch June 22, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant