-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add extracontainers to allow for sidecar #2759
Conversation
WalkthroughThis update increments the version of the CCTP chart from 0.2.2 to 0.3.0. It also enhances Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Deploying sanguine-fe with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
charts/cctp/templates/deployment.yaml (2)
Line range hint
9-9
: Correct the indentation issue flagged by yamllint.- {{- include "cctp.labels" . | nindent 4 }} + {{- include "cctp.labels" . | nindent 2 }}
Line range hint
6-6
: Address the syntax error reported by yamllint.- {{- if not .Values.autoscaling.enabled }} +{{- if not .Values.autoscaling.enabled }}
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- charts/cctp/Chart.yaml (1 hunks)
- charts/cctp/templates/deployment.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
- charts/cctp/Chart.yaml
Additional context used
yamllint
charts/cctp/templates/deployment.yaml
[warning] 9-9: wrong indentation: expected 0 but found 2 (indentation)
[error] 6-6: syntax error: expected the node content, but found '-' (syntax)
Additional comments not posted (1)
charts/cctp/templates/deployment.yaml (1)
60-62
: Ensure the conditional inclusion of extra containers is well-tested.
Description
Using cloudsql databases authenticated via iap requires sidecar containers (alternatively)
Summary by CodeRabbit
New Features
Chores
0.2.2
to0.3.0
.