feat(synapse-interface): upgrade wagmi, viem, rainbowkit to support smartwallet #2674
Conversation
bigboydiamonds
requested review from
abtestingalpha,
aureliusbtc and
trajan0x
as code owners
WalkthroughThis update involves version bumps for several dependencies in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Deploying sanguine with
|
| Latest commit: |
0f519de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2e0656ae.sanguine.pages.dev |
| Branch Preview URL: | https://fe-coinbase-smart-wallet.sanguine.pages.dev |
Deploying sanguine-fe with
|
| Latest commit: |
0f519de
|
| Status: | 🚫 Build failed. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lockis excluded by!**/*.lock
Files selected for processing (1)
- packages/synapse-interface/package.json (2 hunks)
Additional comments not posted (3)
packages/synapse-interface/package.json (3)
32-32: Version update for@rainbow-me/rainbowkitlooks good. Ensure compatibility with new features.
74-74: Version update forwagmilooks good. Ensure all blockchain interactions are tested thoroughly.
73-73: Version update forviemlooks good. Recommend thorough testing of dependent features.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/synapse-interface/package.json (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/synapse-interface/package.json
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2674 +/- ##
===================================================
+ Coverage 39.89549% 39.90228% +0.00678%
===================================================
Files 180 180
Lines 14736 14736
Branches 80 80
===================================================
+ Hits 5879 5880 +1
Misses 8093 8093
+ Partials 764 763 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lockis excluded by!**/*.lock
Files selected for processing (9)
- .nvmrc (1 hunks)
- packages/synapse-interface/actions/approveErc20Token.ts (2 hunks)
- packages/synapse-interface/actions/harvestLpPool.ts (2 hunks)
- packages/synapse-interface/actions/stakeLpToken.ts (2 hunks)
- packages/synapse-interface/actions/swapPoolAddLiquidity.ts (2 hunks)
- packages/synapse-interface/actions/swapPoolRemoveLiquidity.ts (2 hunks)
- packages/synapse-interface/actions/swapPoolRemoveLiquidityOneToken.ts (2 hunks)
- packages/synapse-interface/actions/unstakeLpToken.ts (2 hunks)
- packages/synapse-interface/package.json (4 hunks)
Files skipped from review due to trivial changes (1)
- .nvmrc
Files skipped from review as they are similar to previous changes (1)
- packages/synapse-interface/package.json
Additional comments not posted (10)
packages/synapse-interface/actions/harvestLpPool.ts (1)
2-2: Integration ofSimulateContractParameterslooks correct and enhances type safety.Also applies to: 29-29
Verification successful
The type
SimulateContractParametersis defined locally within each file in thepackages/synapse-interface/actions/directory, ensuring correct usage without the need for imports.
packages/synapse-interface/actions/unstakeLpToken.tspackages/synapse-interface/actions/swapPoolRemoveLiquidity.tspackages/synapse-interface/actions/stakeLpToken.tspackages/synapse-interface/actions/harvestLpPool.tspackages/synapse-interface/actions/approveErc20Token.tspackages/synapse-interface/actions/swapPoolRemoveLiquidityOneToken.tspackages/synapse-interface/actions/swapPoolAddLiquidity.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type typescript $'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 120
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type ts 'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 1382
Script:
#!/bin/bash # Description: Verify the definition and import of `SimulateContractParameters`. # Test: Search for the definition of `SimulateContractParameters`. rg 'type SimulateContractParameters' --files-with-matches # Test: Search for the import of `SimulateContractParameters`. rg 'import.*SimulateContractParameters' packages/synapse-interface/actions/Length of output: 540
Script:
#!/bin/bash # Description: Verify if `SimulateContractParameters` is defined locally in each file or if it should be imported. # Test: Search for the definition of `SimulateContractParameters` within each file. rg 'type SimulateContractParameters' packages/synapse-interface/actions/Length of output: 722
packages/synapse-interface/actions/stakeLpToken.ts (1)
2-2: Consistent use ofSimulateContractParametersacross different actions ensures uniformity and type safety.Also applies to: 31-31
Verification successful
The search results indicate that the
SimulateContractParameterstype is consistently used across multiple files within thepackages/synapse-interface/actions/directory. This suggests that the integration of this type is uniform and likely correct.Files where
SimulateContractParametersis used:
unstakeLpToken.tsswapPoolRemoveLiquidityOneToken.tsswapPoolRemoveLiquidity.tsstakeLpToken.tsswapPoolAddLiquidity.tsapproveErc20Token.tsharvestLpPool.tsConsistent use of
SimulateContractParametersacross different actions ensures uniformity and type safety.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type typescript $'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 120
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type ts 'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 1382
packages/synapse-interface/actions/unstakeLpToken.ts (1)
2-2: Type casting withSimulateContractParametersis correctly applied, ensuring type safety.Also applies to: 31-31
Verification successful
The type
SimulateContractParametersis consistently used across multiple files within thepackages/synapse-interface/actions/directory, includingunstakeLpToken.ts. This indicates that the type integration is uniform and there are no immediate errors or warnings related to its usage.
packages/synapse-interface/actions/unstakeLpToken.tspackages/synapse-interface/actions/swapPoolRemoveLiquidityOneToken.tspackages/synapse-interface/actions/swapPoolRemoveLiquidity.tspackages/synapse-interface/actions/swapPoolAddLiquidity.tspackages/synapse-interface/actions/stakeLpToken.tspackages/synapse-interface/actions/harvestLpPool.tspackages/synapse-interface/actions/approveErc20Token.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type typescript $'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 120
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type ts 'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 1382
packages/synapse-interface/actions/approveErc20Token.ts (1)
2-2: Proper use ofSimulateContractParametersfor type safety in ERC20 token approval.Also applies to: 40-40
Verification successful
The integration of
SimulateContractParametersappears consistent across multiple files within thepackages/synapse-interface/actions/directory. The type is used in various action files without any apparent errors or warnings.
packages/synapse-interface/actions/unstakeLpToken.tspackages/synapse-interface/actions/swapPoolRemoveLiquidityOneToken.tspackages/synapse-interface/actions/swapPoolRemoveLiquidity.tspackages/synapse-interface/actions/stakeLpToken.tspackages/synapse-interface/actions/approveErc20Token.tspackages/synapse-interface/actions/harvestLpPool.tspackages/synapse-interface/actions/swapPoolAddLiquidity.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type typescript $'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 120
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type ts 'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 1382
packages/synapse-interface/actions/swapPoolAddLiquidity.ts (1)
2-2: Correct application ofSimulateContractParametersin liquidity addition actions enhances type safety.Also applies to: 46-49
Verification successful
The integration of
SimulateContractParametersappears consistent across multiple action files, includingswapPoolAddLiquidity.ts. No errors or warnings were found related to the new type usage.
swapPoolAddLiquidity.tscorrectly usesSimulateContractParameters.- Other files such as
unstakeLpToken.ts,swapPoolRemoveLiquidityOneToken.ts, andstakeLpToken.tsalso useSimulateContractParametersconsistently.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type typescript $'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 120
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type ts 'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 1382
packages/synapse-interface/actions/swapPoolRemoveLiquidity.ts (1)
3-3: Consistent and correct use ofSimulateContractParametersin liquidity removal actions ensures type safety.Also applies to: 46-46
Verification successful
The search results indicate that the
SimulateContractParameterstype is consistently used across multiple action files, includingswapPoolRemoveLiquidity.ts. This suggests that the integration of this type is uniform and likely correct.
swapPoolRemoveLiquidity.tsunstakeLpToken.tsswapPoolRemoveLiquidityOneToken.tsstakeLpToken.tsapproveErc20Token.tsswapPoolAddLiquidity.tsharvestLpPool.tsGiven this consistency, it appears that the use of
SimulateContractParametersis well-integrated across the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type typescript $'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 120
Script:
#!/bin/bash # Description: Verify integration with updated libraries. # Test: Search for any errors or warnings related to the new type usage. rg --type ts 'SimulateContractParameters' packages/synapse-interface/actions/Length of output: 1382
packages/synapse-interface/actions/swapPoolRemoveLiquidityOneToken.ts (4)
2-2: Import ofSimulateContractParameterscorrectly added.
Line range hint
9-9: Function signature and parameters are correctly defined for blockchain interactions.
47-47: Correct use ofSimulateContractParametersfor type safety in blockchain operations.
47-47: Return statement is appropriate for the blockchain write operation.
Summary by CodeRabbit
New Features
Chores
v18.18.0for improved compatibility and stability.14a3800acde5bc56f9f7664d2cc6a421a3982cc1: synapse-interface preview link