Index Messaging Contracts with Explorer #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
===================================================
+ Coverage 34.68253% 35.13068% +0.44814%
===================================================
Files 372 379 +7
Lines 38492 38798 +306
Branches 84 84
===================================================
+ Hits 13350 13630 +280
- Misses 23449 23462 +13
- Partials 1693 1706 +13 ☔ View full report in Codecov by Sentry. |
trajan0x
requested changes
Oct 14, 2022
| SourceChainID *big.Int `gorm:"column:source_chain_id;type:UInt256"` | ||
|
|
||
| // Status is the status of the event. | ||
| Status sql.NullString `gorm:"column:status"` |
There was a problem hiding this comment.
What are your thoughts on making this an enum? You can see us doing that here:
There was a problem hiding this comment.
i was considering it, but i thought it would reduce the data conversions down the line if it was just a string like when doing SQL queries. might be wrong about it though.
| // TxHash is the transaction hash of the event | ||
| TxHash string `gorm:"column:tx_hash"` | ||
| // EventType is the type of the event | ||
| EventType uint8 `gorm:"column:event_type"` |
| } else { | ||
| case c.messageAddress: | ||
| eventParser = c.messageParser | ||
| default: | ||
| if c.swapParsers[log.Address] == nil { | ||
| logger.Warnf("no parser found for contract %s", log.Address.Hex()) | ||
| return nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add indexing for message contracts (
MessageBusUpgradeable.sol) to explorer.Additional context
Messaging!