Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webhook): add webhook #2538
feat(webhook): add webhook #2538
Changes from 15 commits
6074411
31aab47
b5e989a
715a453
e2a6214
cd41cbc
444428b
18c0d51
799f646
c22d3c9
6e0d109
9af0630
b5a29e1
496d67a
df7ffc6
0b7b3e9
8b8297a
f8a833b
d4ac8d6
01f8b57
7f81c14
1c55e8b
a5a3120
a7e239e
7d2117a
4c7538c
6fec3a5
200eb8b
5dc99e4
1a3000a
b40e602
f241759
d9e99a0
d7963fa
652b099
d390ea0
8c215e4
498a067
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 21 in contrib/screener-api/client/client.go
GitHub Actions / Lint (contrib/screener-api)
Check failure on line 91 in contrib/screener-api/client/client.go
GitHub Actions / Lint (contrib/screener-api)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poor use of %s, just create a concat(...string) method that does this
Check failure on line 12 in contrib/screener-api/db/db.go
GitHub Actions / Lint (contrib/screener-api)
Check failure on line 19 in contrib/screener-api/db/db.go
GitHub Actions / Lint (contrib/screener-api)
Check failure on line 23 in contrib/screener-api/db/db.go
GitHub Actions / Lint (contrib/screener-api)
Check failure on line 44 in contrib/screener-api/db/db.go
GitHub Actions / Lint (contrib/screener-api)
Check failure on line 24 in contrib/screener-api/db/models.go
GitHub Actions / Lint (contrib/screener-api)
Check failure on line 32 in contrib/screener-api/db/models.go
GitHub Actions / Lint (contrib/screener-api)
Check warning on line 33 in contrib/screener-api/db/models.go
Codecov / codecov/patch
contrib/screener-api/db/models.go#L32-L33
Check failure on line 36 in contrib/screener-api/db/models.go
GitHub Actions / Lint (contrib/screener-api)
Check warning on line 41 in contrib/screener-api/db/models.go
Codecov / codecov/patch
contrib/screener-api/db/models.go#L36-L41
Check failure on line 44 in contrib/screener-api/db/models.go
GitHub Actions / Lint (contrib/screener-api)
Check warning on line 56 in contrib/screener-api/db/models.go
Codecov / codecov/patch
contrib/screener-api/db/models.go#L44-L56
Check warning on line 63 in contrib/screener-api/db/models.go
Codecov / codecov/patch
contrib/screener-api/db/models.go#L58-L63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
The verification process has confirmed that there is no unit test specifically targeting the
Scan
method of theBlacklistedAddress
struct in thecontrib/screener-api/db/models.go
file. The search results included various usages of theScan
method across different contexts, but none that directly test theScan
method within theBlacklistedAddress
struct.Analysis chain
Ensure
Scan
method is covered by unit tests.The
Scan
method is critical for data deserialization, and it is important to ensure its correct implementation through testing.The output from the executed script does not confirm the presence of unit tests for the
Scan
method in theBlacklistedAddress
struct. The results show tests for different contexts, which are not relevant to theBlacklistedAddress
. To ensure thorough verification, I will refine the search to focus specifically on theBlacklistedAddress
struct.Scripts Executed
The following scripts were executed for the analysis:
Script:
Length of output: 406
Script:
Length of output: 5016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a descriptive comment for the
AddressIndicators
struct.+ // AddressIndicators represents the risk indicators associated with an address.
It's a good practice to provide comments for exported types to improve code readability and maintainability.
Committable suggestion
Add a descriptive comment for the
addressRiskIndicators
type.+ // addressRiskIndicators defines a list of risk indicators for an address.
This comment will help other developers understand the purpose of this type at a glance.
Committable suggestion
Add a descriptive comment for the
ToTRMLabs
method.+ // ToTRMLabs converts address risk indicators to a format used by TRMLabs.
Adding a descriptive comment for this exported method will enhance code readability and maintainability.
Committable suggestion
Add a descriptive comment for the
MakeRecord
function.+ // MakeRecord creates a new AddressIndicators record with the specified address and risk indicators.
Documenting public functions helps other developers understand their purpose and usage quickly.
Committable suggestion