Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[goreleaser] fixing explorer UI and explorer indexer #2512

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

Defi-Moses
Copy link
Collaborator

@Defi-Moses Defi-Moses commented Apr 18, 2024

This PR seeks to fix all remaining UI issues in explorer-UI and finalize some db cleanliness moving forward. The following was done:

  • added all the necessary images and symbols for new tokens in the UI (e.g. native ETH)
  • FastBridge Contracts added to synapse-constants and the "bridge contract link" in explorer UI.
  • Updated the explorer indexer to return the amount USD of either the origin or destination amount (and not use the origin amount for both)
  • Dynamically set the "token" field when converting to a bridge event so that the correct token address is shown (and not using the origin token for both)

Summary by CodeRabbit

  • New Features

    • Improved token symbol determination in transaction tables and components.
    • Enhanced asset image rendering with added token symbol display.
    • Introduced handling for new event types in transaction processing.
  • Updates

    • Updated dependencies for improved functionality and compatibility.
  • Bug Fixes

    • Implemented temporary fixes for asset image sourcing issues, particularly for USDC.
  • Refactor

    • Enhanced token address to symbol resolution logic across components and utilities.

5a97aa6cb7f1a50703fefcebbce49a68d78dde8b: explorer-ui preview link
8942fe31bc5991e2ad4bb6ecb66ecd86faf6931a: explorer-ui preview link

Copy link
Contributor

coderabbitai bot commented Apr 18, 2024

Warning

Rate Limit Exceeded

@Defi-Moses has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 45 minutes and 53 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 5dd88e5 and d09c881.

Walkthrough

The updates aim to enhance token representation accuracy and functionality in the Explorer UI by incorporating new utility functions and constants. Changes involve updating dependencies, refining token symbol resolution, and improving image handling. Additionally, the updates address specific bridge and RFQ event handling while refining constant management across different chains.

Changes

File Path Change Summary
.../BridgeTransactionTable.tsx, .../IconAndAmount.tsx, .../addressToSymbol.ts Integrated addressToSymbol and tokenAddressToToken functions for accurate token symbol determination.
.../AssetImage.tsx Enhanced AssetImage component to handle tokenSymbol prop and improved image rendering logic.
.../tx/[kappa].tsx, .../chains/index.ts Added handling for new event types and FASTBRIDGE_CONTRACTS, enhancing URL generation and contract address management.
.../tokens/bridgeable.ts, .../tokens/index.ts Updated token constants, improved functions for token lookup, and standardized use of nullAddress.
.../package.json, .../synapse-constants/package.json Updated synapse-constants package version to 1.3.16.
.../consumer/parser/rfqparser.go Adjusted RFQParser logic for more accurate AmountUSD calculation and event mapping based on EventType.

🐰✨
In the code's burrow, deep and wide,
New changes bloom from inside.
Symbols map and tokens glide,
On data streams, they now ride.
Cheers to the devs, side by side!
🥕🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added go Pull requests that update Go code M-explorer-ui size/s labels Apr 18, 2024
Copy link

cloudflare-workers-and-pages bot commented Apr 18, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: d09c881
Status: ✅  Deploy successful!
Preview URL: https://3b7c7c97.sanguine-fe.pages.dev
Branch Preview URL: https://feat-explorer-ui-rfq.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 47.08605%. Comparing base (fe52a70) to head (d09c881).
Report is 2 commits behind head on master.

Files Patch % Lines
services/explorer/consumer/parser/rfqparser.go 0.00000% 14 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #2512         +/-   ##
===================================================
+ Coverage   46.96157%   47.08605%   +0.12447%     
===================================================
  Files            384         388          +4     
  Lines          29456       29599        +143     
  Branches          83          83                 
===================================================
+ Hits           13833       13937        +104     
- Misses         14169       14204         +35     
- Partials        1454        1458          +4     
Flag Coverage Δ
packages 90.62500% <ø> (ø)
promexporter 75.91241% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliusbtc aureliusbtc merged commit 55ce3da into master Apr 23, 2024
36 of 37 checks passed
@aureliusbtc aureliusbtc deleted the feat/explorer-ui-rfq branch April 23, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code M-explorer-ui size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants