Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Update values for tracking tests #1870

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi commented Jan 16, 2024

Description
Fixes failing CI tests.

Summary by CodeRabbit

  • Tests
    • Updated transaction hashes and addresses in SynapseSDK tests for optimistic and arbitrum chains.

Copy link
Contributor

coderabbitai bot commented Jan 16, 2024

Walkthrough

The recent update to the SynapseSDK involves alterations to the test suite, specifically targeting the transaction hashes and addresses for the Optimistic and Arbitrum chains. These changes reflect an update in the test cases to align with new transaction identifiers and account addresses for these specific Layer 2 solutions.

Changes

File Path Change Summary
.../sdk-router/src/sdk.test.ts Updated transaction hashes and addresses for Optimistic and Arbitrum chains in tests.

🐰✨
To the chains of Optimism and Arbitrum's might,
We've updated hashes and addresses, got them just right.
Through tests, we hop with utmost care,
Ensuring our SynapseSDK is beyond compare. 🌟🌌

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c40345) 51.64072% compared to head (c34908b) 51.18525%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1870         +/-   ##
===================================================
- Coverage   51.64072%   51.18525%   -0.45547%     
===================================================
  Files            409         397         -12     
  Lines          28067       27125        -942     
  Branches         307         307                 
===================================================
- Hits           14494       13884        -610     
+ Misses         12156       11888        -268     
+ Partials        1417        1353         -64     
Flag Coverage Δ
cctp-relayer ?
packages 90.87137% <ø> (-0.10373%) ⬇️
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChiTimesChi ChiTimesChi marked this pull request as ready for review January 16, 2024 11:09
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4c40345 and c34908b.
Files selected for processing (1)
  • packages/sdk-router/src/sdk.test.ts (2 hunks)
Files skipped from review due to trivial changes (1)
  • packages/sdk-router/src/sdk.test.ts

@ChiTimesChi ChiTimesChi merged commit 744d57d into master Jan 16, 2024
35 checks passed
@ChiTimesChi ChiTimesChi deleted the sdk/update-rfq-tests branch January 16, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant