Fe/cctp router update #1622

bigboydiamonds · 2023-12-12T22:00:26Z

Update CCTP Router Addresses

Summary by CodeRabbit

Chores
- Updated contract addresses for the CCTP contracts across various networks to ensure seamless interaction with the updated smart contracts.
- Modified the CCTP Router address to align with the new contract deployment, affecting routing behavior within the application.

f3d8f8a3dfc0da9fc41021bbb2b6b53aff5a43fa: explorer-ui preview link
f3d8f8a3dfc0da9fc41021bbb2b6b53aff5a43fa: synapse-interface preview link
352e3b14ccf9d62e4dc0739a540714f8170d0e3a: explorer-ui preview link
352e3b14ccf9d62e4dc0739a540714f8170d0e3a: synapse-interface preview link
4ddc1d311109fa9989b56ba1ebee2c115449ecee: explorer-ui preview link
4ddc1d311109fa9989b56ba1ebee2c115449ecee: synapse-interface preview link
f874688921ca7f95d78a9218872d709feb7f0128: explorer-ui preview link
f874688921ca7f95d78a9218872d709feb7f0128: synapse-interface preview link

coderabbitai · 2023-12-12T22:00:32Z

Walkthrough

The recent updates across multiple files involve a uniform change of contract addresses to a new value. This change affects how the application interacts with blockchain networks by updating the addresses it references for contract interactions.

Changes

File Path	Change Summary
`packages/explorer-ui/constants/networks.ts`	Updated `CCTP_CONTRACTS` addresses for multiple chains.
`packages/sdk-router/src/constants/addresses.ts` `packages/synapse-interface/utils/actions/fetchPortfolioBalances.tsx`	Updated `CCTP_ROUTER_ADDRESS` to a new contract address.

🐇✨
In the code's warren, deep and wide,
Addresses shift with a hop and slide.
New paths are laid with care and pride,
As the rabbit's work does coincide. 🌟🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

You can reply to a review comment made by CodeRabbit.
You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 62e524c and a7a78eb.

Files selected for processing (3)

packages/explorer-ui/constants/networks.ts (1 hunks)
packages/sdk-router/src/constants/addresses.ts (1 hunks)
packages/synapse-interface/utils/actions/fetchPortfolioBalances.tsx (1 hunks)

Additional comments: 5

packages/explorer-ui/constants/networks.ts (1)

602-607: The updated contract addresses for CCTP_CONTRACTS are consistent with the PR's objective to update the CCTP Router addresses across the codebase. Ensure that the new addresses are valid Ethereum addresses and that they are correctly deployed and functional on their respective networks.
packages/sdk-router/src/constants/addresses.ts (3)
43-43: The update to the CCTP_ROUTER_ADDRESS constant is consistent with the PR's objective to update contract addresses for the CCTP Router.

46-46: The CCTP_ROUTER_ADDRESS_MAP is correctly using the new CCTP_ROUTER_ADDRESS constant to generate address mappings for supported chain IDs.

43-43: The search for the old CCTP_ROUTER_ADDRESS value did not yield any results in the codebase. This suggests that the old address is not being used elsewhere, which aligns with the PR's objective to update the contract addresses for the CCTP Router.

Based on the information provided, it appears that the update has been carried out correctly and there are no references to the old address left in the codebase.

Analysis chain

To ensure that the old CCTP_ROUTER_ADDRESS is not used elsewhere in the codebase, a search for the old address should be conducted.
Scripts Executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Search for the old CCTP_ROUTER_ADDRESS value in the codebase.
rg '0xD359bc471554504f683fbd4f6e36848612349DDF'
Length of output: 47
packages/synapse-interface/utils/actions/fetchPortfolioBalances.tsx (1)

7-8: The addition of CCTP_ROUTER_ADDRESS is consistent with the PR's objective to update CCTP Router addresses. However, it's important to verify if this new constant is intended to replace the existing ROUTER_ADDRESS or if it should be used in conjunction with it. Additionally, ensure that the new constant is being used wherever necessary across the codebase.

codecov · 2023-12-12T22:03:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d7eb8e) 51.35585% compared to head (287008f) 51.35585%.

Additional details and impacted files

@@              Coverage Diff              @@
##              master       #1622   +/-   ##
=============================================
  Coverage   51.35585%   51.35585%           
=============================================
  Files            362         362           
  Lines          24634       24634           
  Branches         284         284           
=============================================
  Hits           12651       12651           
  Misses         10763       10763           
  Partials        1220        1220

Flag	Coverage Δ
packages	`90.77156% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cloudflare-workers-and-pages · 2023-12-12T22:20:19Z

Deploying with Cloudflare Pages

Latest commit:	`287008f`
Status:	✅ Deploy successful!
Preview URL:	https://fb82c01d.sanguine.pages.dev
Branch Preview URL:	https://fe-cctp-router-update.sanguine.pages.dev

View logs

ChiTimesChi · 2023-12-12T23:30:23Z

packages/sdk-router/src/constants/addresses.ts

@@ -40,7 +40,7 @@ export const ROUTER_ADDRESS_MAP: AddressMap = generateAddressMap(
 /**
 * SynapseCCTP contract address for all chains except ones from CCTP_ROUTER_EXCEPTION_MAP.
 */
-const CCTP_ROUTER_ADDRESS = '0xD359bc471554504f683fbd4f6e36848612349DDF'
+const CCTP_ROUTER_ADDRESS = '0xd5a597d6e7ddf373a92C8f477DAAA673b0902F48'


Let's revert this change: this is dealt with in #1617

Updated in 49dae15

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between a7a78eb and 49dae15.

Files selected for processing (1)

packages/explorer-ui/constants/networks.ts (1 hunks)

packages/explorer-ui/constants/networks.ts

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 49dae15 and b8f8615.

Files selected for processing (1)

packages/synapse-interface/utils/actions/fetchPortfolioBalances.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (1)

packages/synapse-interface/utils/actions/fetchPortfolioBalances.tsx

ChiTimesChi · 2023-12-13T00:58:29Z

Closing this: the router address update was moved to #1627

bigboydiamonds added 2 commits December 12, 2023 13:57

Update CCTP Router Address

5d149d3

Update CCTP router addresses

a7a78eb

bigboydiamonds requested review from abtestingalpha, nautsimon, aureliusbtc, trajan0x and ChiTimesChi as code owners December 12, 2023 22:00

github-actions bot added M-explorer-ui M-synapse-interface size/xs labels Dec 12, 2023

coderabbitai bot reviewed Dec 12, 2023

View reviewed changes

ChiTimesChi requested changes Dec 12, 2023

View reviewed changes

bigboydiamonds added 3 commits December 12, 2023 15:56

Add Polygon and Optimism CCTP Contract, update router address

09cf9bd

Revert change

49dae15

Update address in fetchPortfolioBlaances

b8f8615

coderabbitai bot reviewed Dec 13, 2023

View reviewed changes

packages/explorer-ui/constants/networks.ts Show resolved Hide resolved

coderabbitai bot reviewed Dec 13, 2023

View reviewed changes

bigboydiamonds requested a review from ChiTimesChi December 13, 2023 00:03

Merge branch 'master' into fe/cctp-router-update

287008f

ChiTimesChi closed this Dec 13, 2023

ChiTimesChi deleted the fe/cctp-router-update branch December 13, 2023 00:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fe/cctp router update #1622

Fe/cctp router update #1622

bigboydiamonds commented Dec 12, 2023 •

edited by github-actions bot

Loading

coderabbitai bot commented Dec 12, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

coderabbitai bot left a comment

codecov bot commented Dec 12, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 12, 2023 •

edited

Loading

ChiTimesChi Dec 12, 2023

bigboydiamonds Dec 13, 2023

coderabbitai bot left a comment

coderabbitai bot left a comment

ChiTimesChi commented Dec 13, 2023

Fe/cctp router update #1622

Fe/cctp router update #1622

Conversation

bigboydiamonds commented Dec 12, 2023 • edited by github-actions bot Loading

Summary by CodeRabbit

coderabbitai bot commented Dec 12, 2023 • edited Loading

Walkthrough

Changes

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 12, 2023 • edited Loading

Codecov Report

cloudflare-workers-and-pages bot commented Dec 12, 2023 • edited Loading

Deploying with Cloudflare Pages

ChiTimesChi Dec 12, 2023

Choose a reason for hiding this comment

bigboydiamonds Dec 13, 2023

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

ChiTimesChi commented Dec 13, 2023

bigboydiamonds commented Dec 12, 2023 •

edited by github-actions bot

Loading

coderabbitai bot commented Dec 12, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Dec 12, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 12, 2023 •

edited

Loading