Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use older foundry nigthly for forge doc #1577

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi commented Nov 20, 2023

Description
Uses a pinned nightly from November 1st for forge doc. It looks as if the latest nightly has a regression that causes forge doc to fail.

Summary by CodeRabbit

  • Refactor
    • Updated the Foundry toolchain to a specific nightly version to resolve issues with documentation generation.
    • Upgraded the Vercel CLI to version 30.1.0 for improved deployment processes.

Copy link
Contributor

coderabbitai bot commented Nov 20, 2023

Walkthrough

The update focuses on stabilizing the development environment by pinning the Foundry toolchain to a specific nightly version to resolve issues with the forge doc command. Additionally, the Vercel CLI tool is upgraded to ensure compatibility with the latest features and fixes.

Changes

File Path Change Summary
.github/workflows/solidity.yml Pinned Foundry toolchain to a specific nightly version and updated Vercel CLI to version 30.1.0.

🐇 In the code's silent night, a fix takes flight, 🌙✨
With a version pin, stability's win, in the developer's delight. 🛠️💖
As autumn leaves fall, we code through it all, with updates so right. 🍂👩‍💻
No bug too small, for the rabbit's keen sight! 🐰🔍


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@github-actions github-actions bot added M-ci Module: CI size/xs labels Nov 20, 2023
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 861d07a and 48dce58.
Files selected for processing (1)
  • .github/workflows/solidity.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/solidity.yml

@ChiTimesChi ChiTimesChi merged commit 7942800 into master Nov 20, 2023
35 checks passed
@ChiTimesChi ChiTimesChi deleted the ci/solidity-docs-rollback-foundry branch November 20, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-ci Module: CI size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant