Update avascan link #1566
Merged
Update avascan link #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigboydiamonds
requested review from
abtestingalpha,
nautsimon and
aureliusbtc
as code owners
WalkthroughThe recent updates involve a uniform change across multiple files, where the URL for the Avalanche blockchain explorer has been modified. The previous URL 'https://avascan.info/' has been replaced with 'https://avascan.info/blockchain/c/', refining the link to direct users to a more specific subsection of the Avascan website. Changes
TipsChat with CodeRabbit Bot (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1566 +/- ##
=============================================
Coverage 51.26346% 51.26346%
=============================================
Files 362 362
Lines 24694 24694
Branches 283 283
=============================================
Hits 12659 12659
Misses 10807 10807
Partials 1228 1228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/synapse-interface/constants/chains/master.tsx (1 hunks)
Additional comments: 1
packages/synapse-interface/constants/chains/master.tsx (1)
- 119-125: The URL change from 'https://avascan.info/' to 'https://avascan.info/blockchain/c/' is specific and seems to point directly to the Avalanche C-Chain explorer. This is a good change if the intention is to direct users to the C-Chain specifically, as Avalanche has multiple chains (X, P, and C). However, ensure that this change is communicated to users if they are accustomed to navigating from the general Avascan homepage to the specific chain explorer.
Deploying with
|
| Latest commit: |
fe1898f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://242d1fe9.sanguine.pages.dev |
| Branch Preview URL: | https://fe-avascan.sanguine.pages.dev |
abtestingalpha
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/explorer-ui/constants/networks.ts (1 hunks)
Additional comments: 1
packages/explorer-ui/constants/networks.ts (1)
- 296-296: The URL for the Avalanche blockchain explorer has been updated to point to the C-Chain explorer. This change should be verified to ensure that it correctly reflects the intended destination and that there are no other places in the codebase where the old URL might still be used.
Additional Considerations
- It's important to check if there are any hardcoded URLs in the codebase that might also need updating.
- Ensure that the updated URL is reflected in all user-facing components where the explorer link might be displayed.
- Verify that the change does not affect any backend services that might be using the old URL for data retrieval or other purposes.
- It might be beneficial to search for the old URL string in the entire codebase to ensure that no instances have been missed.
- If the URL structure is subject to change again in the future, consider implementing a more centralized or configurable approach to manage such URLs to simplify future updates.
Updated explorer link fe1898f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
8aad429059da6d73ac47da1d4b3299061e02ab85: synapse-interface preview link
e2e6bc91d1bb2b117a843d9dcb657eabe11b8ae0: synapse-interface preview link
e2e6bc91d1bb2b117a843d9dcb657eabe11b8ae0: explorer-ui preview link