Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds spender address to eth syn sushi token #1550

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

abtestingalpha
Copy link
Collaborator

@abtestingalpha abtestingalpha commented Nov 9, 2023

Summary by CodeRabbit

  • New Features
    • Updated the initialization of the SYN_ETH_SUSHI_TOKEN to include the miniChefAddress property.
  • Bug Fixes
    • Adjusted the poolId value in the ETH_POOL_SWAP_TOKEN configuration for the Ethereum Stableswap Pool.

a27602c4e174a5edc96f147fe20c7086baabf710: synapse-interface preview link
fe8d4668f1e20b8a2c48a5c96b99526e88d78738: synapse-interface preview link

Copy link
Contributor

coderabbitai bot commented Nov 9, 2023

Walkthrough

The changes primarily focus on the configuration of the SYN_ETH_SUSHI_TOKEN and ETH_POOL_SWAP_TOKEN tokens in the Synapse Interface. The SYN_ETH_SUSHI_TOKEN now retrieves its miniChefAddress from the MINICHEF_ADDRESSES module, while the ETH_POOL_SWAP_TOKEN has its poolId value updated from 0 to 420.

Changes

File Path Change Summary
.../tokens/sushiMaster.ts Imported MINICHEF_ADDRESSES from minichef module. Assigned miniChefAddress of SYN_ETH_SUSHI_TOKEN to value from MINICHEF_ADDRESSES based on chain ID.
.../tokens/poolMaster.ts Updated poolId value from 0 to 420 in ETH_POOL_SWAP_TOKEN export within Ethereum Stableswap Pool configuration.

Poem

🐇 Hopping through the code, with changes in our stride,
On this day in history, with autumn by our side. 🍂

Importing from minichef, a tasty treat indeed,
And changing poolId values, to meet the Stableswap's need. 🔄

Celebrating changes, in the glow of the moon's light,
CodeRabbit's journey continues, into the crisp November night. 🌙


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c1f8150 and 699d04b.
Files selected for processing (1)
  • packages/synapse-interface/constants/tokens/sushiMaster.ts (2 hunks)
Additional comments: 3
packages/synapse-interface/constants/tokens/sushiMaster.ts (3)
  • 2-5: The import of MINICHEF_ADDRESSES from the minichef module is correct and should work as expected, assuming that the module exports this constant.

  • 7-8: The initialization of SYN_ETH_SUSHI_TOKEN is correct. Ensure that the Token constructor can handle the new miniChefAddress property.

  • 21-21: The assignment of miniChefAddress is correct, assuming that MINICHEF_ADDRESSES is an object with keys corresponding to chain IDs. Ensure that MINICHEF_ADDRESSES contains a key for CHAINS.ETH.id.

+  miniChefAddress: MINICHEF_ADDRESSES[CHAINS.ETH.id],

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d27fee) 51.23324% compared to head (5f68680) 51.23324%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##              master       #1550   +/-   ##
=============================================
  Coverage   51.23324%   51.23324%           
=============================================
  Files            362         362           
  Lines          24691       24691           
  Branches         283         283           
=============================================
  Hits           12650       12650           
  Misses         10813       10813           
  Partials        1228        1228           
Flag Coverage Δ
packages 91.00610% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Nov 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f68680
Status: ✅  Deploy successful!
Preview URL: https://8b8657af.sanguine.pages.dev
Branch Preview URL: https://fe-fix-showing-eth-syn-pool.sanguine.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 699d04b and 5f68680.
Files selected for processing (1)
  • packages/synapse-interface/constants/tokens/poolMaster.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/synapse-interface/constants/tokens/poolMaster.ts

Copy link
Collaborator

@ChiTimesChi ChiTimesChi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - seeing the fix worked

@abtestingalpha abtestingalpha merged commit a1d08d0 into master Nov 9, 2023
44 checks passed
@abtestingalpha abtestingalpha deleted the fe/fix-showing-eth-syn-pool-stake branch November 9, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants