-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds spender address to eth syn sushi token #1550
Conversation
WalkthroughThe changes primarily focus on the configuration of the Changes
Poem
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/synapse-interface/constants/tokens/sushiMaster.ts (2 hunks)
Additional comments: 3
packages/synapse-interface/constants/tokens/sushiMaster.ts (3)
2-5: The import of
MINICHEF_ADDRESSES
from theminichef
module is correct and should work as expected, assuming that the module exports this constant.7-8: The initialization of
SYN_ETH_SUSHI_TOKEN
is correct. Ensure that theToken
constructor can handle the newminiChefAddress
property.21-21: The assignment of
miniChefAddress
is correct, assuming thatMINICHEF_ADDRESSES
is an object with keys corresponding to chain IDs. Ensure thatMINICHEF_ADDRESSES
contains a key forCHAINS.ETH.id
.+ miniChefAddress: MINICHEF_ADDRESSES[CHAINS.ETH.id],
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1550 +/- ##
=============================================
Coverage 51.23324% 51.23324%
=============================================
Files 362 362
Lines 24691 24691
Branches 283 283
=============================================
Hits 12650 12650
Misses 10813 10813
Partials 1228 1228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/synapse-interface/constants/tokens/poolMaster.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/synapse-interface/constants/tokens/poolMaster.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - seeing the fix worked
Summary by CodeRabbit
SYN_ETH_SUSHI_TOKEN
to include theminiChefAddress
property.poolId
value in theETH_POOL_SWAP_TOKEN
configuration for the Ethereum Stableswap Pool.a27602c4e174a5edc96f147fe20c7086baabf710: synapse-interface preview link
fe8d4668f1e20b8a2c48a5c96b99526e88d78738: synapse-interface preview link