Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fe/bridge input reset behavior #1548

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

bigboydiamonds
Copy link
Collaborator

@bigboydiamonds bigboydiamonds commented Nov 8, 2023

Summary by CodeRabbit

  • Refactor
    • Removed unnecessary cache reset functionality from the Portfolio component.
    • Simplified the process of connecting a new address by removing redundant validation and cache reset steps.

03aa9bd1637c62fa1eb5d7ab0de5e72c8c314d0d: synapse-interface preview link

Copy link
Contributor

coderabbitai bot commented Nov 8, 2023

Walkthrough

The changes primarily revolve around the removal of the resetReduxCache function and related dispatch calls from the Portfolio component and the updater.tsx file in the synapse-interface package. This suggests a shift in the way the application handles cache management.

Changes

File Path Change Summary
.../Portfolio/Portfolio.tsx Removed resetReduxCache function from imports and dispatch calls. Also, removed dispatch(resetBridgeInputs()) call from a useEffect hook.
.../slices/application/updater.tsx Removed condition for address validation before clearing redux cache and dispatch for resetting redux cache when a new address connects. Also, removed console log statement for cache reset.

Poem

🍂 As the leaves fall this November day, 🍁

Code changes dance in a ballet. 🩰

Redux cache reset, no longer in play, 🚫

Making way for a new cache relay. 🔄

On this day in history, the X-ray was found, 💀

Just like our code, profound and sound. 🎵

So let's celebrate these changes, so astound, 🎉

In the codebase's fertile ground. 🌱


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 254c615 and 56fb38a.
Files selected for processing (2)
  • packages/synapse-interface/components/Portfolio/Portfolio.tsx (3 hunks)
  • packages/synapse-interface/slices/application/updater.tsx (2 hunks)
Files skipped from review due to trivial changes (1)
  • packages/synapse-interface/components/Portfolio/Portfolio.tsx
Additional comments: 1
packages/synapse-interface/slices/application/updater.tsx (1)
  • 34-38: The condition to check if the last connected address is valid and different from the current address has been removed. This used to trigger a reset of the transactions state. Make sure that this change doesn't introduce any unintended side effects, especially if other parts of the code rely on this reset behavior.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d27fee) 51.23324% compared to head (56fb38a) 51.23324%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##              master       #1548   +/-   ##
=============================================
  Coverage   51.23324%   51.23324%           
=============================================
  Files            362         362           
  Lines          24691       24691           
  Branches         283         283           
=============================================
  Hits           12650       12650           
  Misses         10813       10813           
  Partials        1228        1228           
Flag Coverage Δ
packages 91.00610% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 56fb38a
Status: ✅  Deploy successful!
Preview URL: https://66e9888d.sanguine.pages.dev
Branch Preview URL: https://fe-bridge-input-reset-behavi.sanguine.pages.dev

View logs

@bigboydiamonds bigboydiamonds merged commit 94a1ecd into master Nov 8, 2023
43 checks passed
@bigboydiamonds bigboydiamonds deleted the fe/bridge-input-reset-behavior branch November 8, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants