-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fe/bridge input reset behavior #1548
Conversation
WalkthroughThe changes primarily revolve around the removal of the Changes
Poem
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (2)
- packages/synapse-interface/components/Portfolio/Portfolio.tsx (3 hunks)
- packages/synapse-interface/slices/application/updater.tsx (2 hunks)
Files skipped from review due to trivial changes (1)
- packages/synapse-interface/components/Portfolio/Portfolio.tsx
Additional comments: 1
packages/synapse-interface/slices/application/updater.tsx (1)
- 34-38: The condition to check if the last connected address is valid and different from the current address has been removed. This used to trigger a reset of the transactions state. Make sure that this change doesn't introduce any unintended side effects, especially if other parts of the code rely on this reset behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1548 +/- ##
=============================================
Coverage 51.23324% 51.23324%
=============================================
Files 362 362
Lines 24691 24691
Branches 283 283
=============================================
Hits 12650 12650
Misses 10813 10813
Partials 1228 1228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying with Cloudflare Pages
|
Summary by CodeRabbit
03aa9bd1637c62fa1eb5d7ab0de5e72c8c314d0d: synapse-interface preview link