-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes deprecated field #1540
Removes deprecated field #1540
Conversation
WalkthroughThe changes revolve around simplifying the Changes
Poem
TipsChat with CodeRabbit Bot (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1540 +/- ##
=============================================
Coverage 51.23324% 51.23324%
=============================================
Files 362 362
Lines 24691 24691
Branches 283 283
=============================================
Hits 12650 12650
Misses 10813 10813
Partials 1228 1228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- packages/synapse-interface/components/StateManagedBridge/InputContainer.tsx (1 hunks)
- packages/synapse-interface/pages/state-managed-bridge/index.tsx (2 hunks)
- packages/synapse-interface/slices/bridge/reducer.ts (4 hunks)
Files skipped from review due to trivial changes (1)
- packages/synapse-interface/slices/bridge/reducer.ts
Additional comments: 2
packages/synapse-interface/pages/state-managed-bridge/index.tsx (1)
- 439-441: The
addBridgeTxHash
dispatch call has been removed. Ensure that this does not affect any other parts of the code that might be relying on this action.packages/synapse-interface/components/StateManagedBridge/InputContainer.tsx (1)
- 19-36: The
hasMounted
state and its relateduseEffect
hook are removed. This simplifies the component's state management and lifecycle. Ensure that this change doesn't affect the component's behavior in edge cases, such as during the initial render.
Deploying with Cloudflare Pages
|
Summary by CodeRabbit
InputContainer
component by removing unnecessary states and logic.addBridgeTxHash
dispatch call from theStateManagedBridge
component.BridgeState
interface and itsinitialState
by removing thebridgeTxHashes
property and theaddBridgeTxHash
action creator.530d560bf444e2459dc56ff59534f93d0383121b: synapse-interface preview link